Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Flipper to 0.44.0 #29033

Closed
wants to merge 3 commits into from
Closed

Upgrade Flipper to 0.44.0 #29033

wants to merge 3 commits into from

Conversation

sunnylqm
Copy link
Contributor

@sunnylqm sunnylqm commented Jun 2, 2020

Summary

Current flipper version would:

  1. block form data request on android. The patch was landed on 0.39 facebook/flipper@f3edfb3
  2. crash when using base64 image on ios. The patch was landed on 0.37
    facebook/flipper@e44c7f4

Fixes #28551 , and #28469

Changelog

[Android] [Changed] - Upgrade Flipper to 0.44.0
[iOS] [Changed] - Upgrade Flipper to 0.44.0

Test Plan

RNTester build pass

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 2, 2020
@react-native-bot react-native-bot added the Platform: Android Android applications. label Jun 2, 2020
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,763,992 0
android hermes armeabi-v7a 6,426,224 0
android hermes x86 7,149,243 0
android hermes x86_64 7,039,745 0
android jsc arm64-v8a 8,932,495 0
android jsc armeabi-v7a 8,587,102 0
android jsc x86 8,760,865 0
android jsc x86_64 9,337,009 0

Base commit: 150d7f6

@analysis-bot
Copy link

analysis-bot commented Jun 2, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal 10,731,152 0

Base commit: 150d7f6

@anthony1110
Copy link

Hi All, I know how to upgrade Flipper version at android but how can I upgrade IOS Flipper version to 0.44 at ios/podfile there?

@sunnylqm

This comment has been minimized.

@anthony1110
Copy link

anthony1110 commented Jul 24, 2020

@anthony1110 For 0.62 you can modify ios/Podfile, for 0.63 currently you have to modify node_modules/react-native/scripts/react_native_pods.rb

@sunnylqm , I am using RN 0.63. Thanks for the info on how to upgrade Flipper

@sunnylqm
Copy link
Contributor Author

sunnylqm commented Aug 1, 2020

@anthony1110 Just found that you can pass the version in iod/Podfile, e.g,

use_flipper!('Flipper' => '0.51.0')

@safaiyeh
Copy link
Contributor

Closing as flipper upgrade has been merged to a higher version than this PR

@safaiyeh safaiyeh closed this Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Platform: Android Android applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React Native 0.62.* [TypeError: Network request failed] on file upload
6 participants