Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Fix TextInput Cursor jumping to the right when the placeholder null #28995

Closed
wants to merge 5 commits into from
Closed

[Android] Fix TextInput Cursor jumping to the right when the placeholder null #28995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
20a9473
fix textinput cursor jump to right when input null
fabOnReact May 28, 2020
2260e47
Merge branch 'master' into fix-text-input-cursor-jump
fabOnReact Feb 15, 2021
3499f3d
use only string placeholder and avoid passing null value to Java
fabOnReact Feb 15, 2021
9651faa
Merge branch 'master' into fix-text-input-cursor-jump
fabOnReact Feb 16, 2021
863ffe7
remove changes to JavaScript placeholder type
fabOnReact Feb 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Libraries/Components/TextInput/TextInput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1107,6 +1107,7 @@ function InternalTextInput(props: Props): React.Node {
} else if (Platform.OS === 'android') {
const style = [props.style];
const autoCapitalize = props.autoCapitalize || 'sentences';
const placeholder = props.placeholder || '';
let children = props.children;
const childCount = React.Children.count(children);
invariant(
Expand Down Expand Up @@ -1135,6 +1136,7 @@ function InternalTextInput(props: Props): React.Node {
* with the props for TextInput. This will need to get fixed */
onScroll={_onScroll}
onSelectionChange={_onSelectionChange}
placeholder={placeholder}
selection={selection}
style={style}
text={text}
Expand Down
2 changes: 1 addition & 1 deletion ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ public void setAllowFontScaling(ReactEditText view, boolean allowFontScaling) {
}

@ReactProp(name = "placeholder")
public void setPlaceholder(ReactEditText view, @Nullable String placeholder) {
public void setPlaceholder(ReactEditText view, String placeholder) {
view.setHint(placeholder);
}

Expand Down