Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump FlipperKit version on iOS to be compatible with react-native-flipper #28277

Closed
wants to merge 1 commit into from

Conversation

mweststrate
Copy link
Contributor

@mweststrate mweststrate commented Mar 10, 2020

Summary

This pull request re-applies #28225, thereby reverting 4bb1794, this time bumping to FlipperKit 0.33.1 which is again compatible with iOS 9 (thanks to facebook/flipper#874)

This is the iOS counterpart of #28275

Changelog

[iOS] [Changed] - Upgrade Flipper dependency to 0.33.1

Test Plan

  • Bumped the version in our Flipper / RN integration test app first, that runs on 0.62-rc.5, verified everything still works there.
  • CI

Screen Shot 2020-03-10 at 12 12 46

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Mar 10, 2020
@pull-bot
Copy link

Messages
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against 527b96f

@react-native-bot react-native-bot added the Platform: iOS iOS applications. label Mar 10, 2020
@analysis-bot
Copy link

RNTester.app (iOS): 10715136 bytes

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheSavior has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @mweststrate in 85a4b0f.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Mar 10, 2020
alloy pushed a commit that referenced this pull request Mar 11, 2020
…pper (#28277)

Summary:
This pull request re-applies #28225, thereby reverting 4bb1794, this time bumping to FlipperKit 0.33.1 which is again compatible with iOS 9 (thanks to facebook/flipper#874)

This is the iOS counterpart of #28275

[iOS] [Changed] - Upgrade Flipper dependency to 0.33.1
Pull Request resolved: #28277

Test Plan:
* Bumped the version in our Flipper / RN integration test app first, that runs on 0.62-rc.5, verified everything still works there.
* CI

![Screen Shot 2020-03-10 at 12 12 46](https://user-images.githubusercontent.com/1820292/76311312-94f09f00-62c8-11ea-81db-ced6d16e096b.png)

Reviewed By: mweststrate

Differential Revision: D20369106

Pulled By: TheSavior

fbshipit-source-id: dfeb0446e7f29684a266eca5d0e29ac42cef2ef3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner Platform: iOS iOS applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants