Skip to content

[Android] Upgrade Folly to v2020.01.13.00 #27811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Android] Upgrade Folly to v2020.01.13.00 #27811

wants to merge 1 commit into from

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Jan 20, 2020

Summary

Upgrade Folly to v2020.01.13.00. Fixes #27640

Changelog

[Android] [Changed] - Upgrade Folly to v2020.01.13.00

Test Plan

Test by building and running RNTester:
./gradlew :RNTester:android:app:installJscDebug
./gradlew :RNTester:android:app:installHermesDebug
And the native debug builds:
NATIVE_BUILD_TYPE=Debug ./gradlew :RNTester:android:app:installJscDebug
NATIVE_BUILD_TYPE=Debug ./gradlew :RNTester:android:app:installHermesDebug

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. labels Jan 20, 2020
@react-native-bot react-native-bot added the Platform: Android Android applications. label Jan 20, 2020
@dulmandakh dulmandakh requested a review from fkgozali January 20, 2020 03:02
@Kudo
Copy link
Contributor Author

Kudo commented Jan 20, 2020

For iOS CI build break, it looks like the CircleCI build accidentally use #27810's cache result.
https://app.circleci.com/jobs/github/facebook/react-native/129192/parallel-runs/0/steps/0-110
https://app.circleci.com/jobs/github/facebook/react-native/129177

For Android, it should not be a problem.

facebook-github-bot
facebook-github-bot reviewed Jan 21, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fkgozali has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@fkgozali
Copy link
Contributor

Can you update the iOS version too? Or was it already upgraded?

@Kudo
Copy link
Contributor Author

Kudo commented Jan 21, 2020

iOS upgrade is at #27810.

@fkgozali
Copy link
Contributor

We're landing both Android and iOS upgrades today.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @Kudo in 6e2131b.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jan 21, 2020
@Kudo
Copy link
Contributor Author

Kudo commented Jan 22, 2020

Thanks @fkgozali for landing these PRs so fast. ❤️

osdnk pushed a commit to osdnk/react-native that referenced this pull request Mar 9, 2020
@Kudo @osdnk
Upgrade Folly to v2020.01.13.00 (facebook#27811)
2c5dac2 
Summary:
Upgrade Folly to v2020.01.13.00. Fixes facebook#27640

## Changelog

[Android] [Changed] - Upgrade Folly to v2020.01.13.00
Pull Request resolved: facebook#27811

Test Plan:
Test by building and running RNTester:
`./gradlew :RNTester:android:app:installJscDebug`
`./gradlew :RNTester:android:app:installHermesDebug`
And the native debug builds:
`NATIVE_BUILD_TYPE=Debug ./gradlew :RNTester:android:app:installJscDebug`
`NATIVE_BUILD_TYPE=Debug ./gradlew :RNTester:android:app:installHermesDebug`

Reviewed By: mdvacca

Differential Revision: D19474027

Pulled By: fkgozali

fbshipit-source-id: 1c680dd80413b63aad66b587213de7499197177c
@willholen willholen mentioned this pull request Mar 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@fkgozali fkgozali Awaiting requested review from fkgozali

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Merged This PR has been merged. Platform: Android Android applications.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Security vulnerability in Folly (CVE-2019-11934)
4 participants
@Kudo @fkgozali @react-native-bot @facebook-github-bot