Fix android modal not disappear when reload #27542
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
Component: Modal
Platform: Android
mdvacca
approved these changes
Dec 19, 2019
facebook-github-bot
approved these changes
Dec 19, 2019
There was a problem hiding this comment.
@mdvacca is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @sunnylqm in 5ddf00e. When will my fix make it into a release? | Upcoming Releases |
rickhanlonii
pushed a commit
that referenced
this pull request
Dec 20, 2019
Summary: Fixes #17986 See above issue After apply this change:  ## Changelog [Android] [Fixed] - Fix android modal not disappear when reload Pull Request resolved: #27542 Test Plan: Open a modal and do a refresh to see whether it disappears Differential Revision: D19178803 Pulled By: mdvacca fbshipit-source-id: 61894927fc481650804b2196df06a80c16b64e6c
KusStar
pushed a commit
to KusStar/react-native
that referenced
this pull request
May 23, 2021
Summary: Fixes facebook#17986 See above issue After apply this change:  ## Changelog [Android] [Fixed] - Fix android modal not disappear when reload Pull Request resolved: facebook#27542 Test Plan: Open a modal and do a refresh to see whether it disappears Differential Revision: D19178803 Pulled By: mdvacca fbshipit-source-id: 61894927fc481650804b2196df06a80c16b64e6c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17986
Summary
See above issue
After apply this change:
Changelog
[Android] [Fixed] - Fix android modal not disappear when reload
Test Plan
Open a modal and do a refresh to see whether it disappears