-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RNTester: Migrate TransformExample to hooks #27181
RNTester: Migrate TransformExample to hooks #27181
Conversation
The original version of this component had no logic to stop the animated loop callback from being fired when the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdvacca is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
The land operation failed because of flow errors:
react-native-github/RNTester/js/examples/Transform/TransformExample.js:193:15 References: Error --------------------------------------------------------------------------- react-native-github/RNTester/js/examples/Transform/TransformExample.js:201:15 References: |
Pushed the fix for the Flow errors. Missed those after I swapped the import style! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdvacca is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This pull request was successfully merged by @empyrical in 58726ce. When will my fix make it into a release? | Upcoming Releases |
Summary
This pull request migrates the animated flip example in
TransformExample
to using React Hooks.Changelog
[General] [Changed] - RNTester: Migrate TransformExample to hooks
Test Plan
The animation works exactly as it did as when it was a class component