[android][gradle] Use Node's module resolution algo to find JSC & Hermes #26773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
ide
force-pushed
the
gradle-node-resolution
branch
from
9ac9059 to
0c8cf42
Compare
The Gradle build file looks up jsc-android and hermes-engine using hard-coded paths. Rather than assuming the location of these packages, which are distributed and installed as npm packages, this commit makes the Gradle file use Node's standard module resolution algorithm. It looks up the file hierarchy until it finds a matching npm package or reaches the root directory. Test plan: Ensure that CI tests pass, and that `./gradlew :ReactAndroid:installArchives` works. Printed out the paths that the Gradle script found for jsc-android and hermes-engine (both were `<my stuff>/react-native/node_modules/jsc-android|hermes-engine`).
ide
force-pushed
the
gradle-node-resolution
branch
from
0c8cf42 to
edd8a81
Compare
janicduplessis
suggested changes
Oct 9, 2019
|
Removed the hard-coded edge cases and explained in a comment the various repo structures this new approach automatically handles. Error handling is better too. |
Janic pointed out that the various hard-coded paths used to find npm packages are no longer needed because the general Node module resolution algorithm takes care of those cases. Added comments to `findNodeModulePath` to explain that it handles those cases.
ide
force-pushed
the
gradle-node-resolution
branch
from
25178f4 to
4ba7809
Compare
janicduplessis
approved these changes
Oct 10, 2019
cpojer
approved these changes
Oct 14, 2019
facebook-github-bot
approved these changes
Oct 14, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @ide in fc25f28. When will my fix make it into a release? | Upcoming Releases |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 5, 2023
Summary: DiffTrain build for commit facebook/react@f533cee. Changelog: [Internal] << DO NOT EDIT BELOW THIS LINE >> Reviewed By: christophpurrer Differential Revision: D45540265 Pulled By: tyao1 fbshipit-source-id: 3dd365f0569953075c61f7fdca2eb099f1bf98d7
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: DiffTrain build for commit facebook/react@f533cee. Changelog: [Internal] << DO NOT EDIT BELOW THIS LINE >> Reviewed By: christophpurrer Differential Revision: D45540265 Pulled By: tyao1 fbshipit-source-id: 3dd365f0569953075c61f7fdca2eb099f1bf98d7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Gradle build file looks up jsc-android and hermes-engine using hard-coded paths. Rather than assuming the location of these packages, which are distributed and installed as npm packages, this commit makes the Gradle file use Node's standard module resolution algorithm. It looks up the file hierarchy until it finds a matching npm package or reaches the root directory.
Changelog
[Android] [Changed] - ReactAndroid's Gradle file uses Node's module resolution algorithm to find JSC & Hermes
Test Plan
Ensure that CI tests pass, and that
./gradlew :ReactAndroid:installArchivesworks. Printed out the paths that the Gradle script found for jsc-android and hermes-engine (both were<my stuff>/react-native/node_modules/jsc-android|hermes-engine).