Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TM] Add TurboModules (jsireact) to Xcode project #25031

Closed
wants to merge 12 commits into from
Closed

[TM] Add TurboModules (jsireact) to Xcode project #25031

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
23ddca8
Add ReactCommon/turbomodule & jsinvoker to Xcode project
radex May 24, 2019
c5f3e22
Missing RCTTurboModule compiled & headers copied
radex May 24, 2019
8160a38
Fix accidental duplicate
radex May 24, 2019
19f143a
RCTTurboModule.xcodeproj
radex May 24, 2019
3581106
RCTTurboModules.xcodeproj - part 2
radex May 24, 2019
2469097
[TM] Compile RNTester with RCTTurboModules
radex May 24, 2019
7f8fdec
Get RNTester working
radex May 24, 2019
3e0f5a9
fix missing bits
radex May 24, 2019
2a5eae5
Remove references to TM bits from React.xcodeproj
radex May 24, 2019
ba4cc9c
RCTTurboModule{Core,Samples}
radex May 30, 2019
de5ac50
Merge branch 'master' of https://github.com/facebook/react-native int…
radex Jun 20, 2019
80fa21e
Remove changes to RNTester
radex Jun 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix missing bits
  • Loading branch information
@radex
radex committed May 24, 2019
commit 3e0f5a928ef48e087fed435d5301f28ddb46508e
8 changes: 4 additions & 4 deletions RNTester/RNTester/RNTesterTurboModuleProvider.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

#import "RNTesterTurboModuleProvider.h"

//#import <jsireact/SampleTurboCxxModule.h>
#import <jsireact/SampleTurboCxxModule.h>
#import <jsireact/RCTSampleTurboModule.h>

// NOTE: This entire file should be codegen'ed.
Expand All @@ -19,9 +19,9 @@
namespace react {

std::shared_ptr<TurboModule> RNTesterTurboModuleProvider(const std::string &name, std::shared_ptr<JSCallInvoker> jsInvoker) {
// if (name == "SampleTurboCxxModule") {
// return std::make_shared<SampleTurboCxxModule>(jsInvoker);
// }
if (name == "SampleTurboCxxModule") {
return std::make_shared<SampleTurboCxxModule>(jsInvoker);
}

return nullptr;
}
Expand Down