[CI] Fix ios/android e2e tests #24974
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
Platform: Android
cpojer
approved these changes
May 21, 2019
facebook-github-bot
approved these changes
May 21, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @nossbigg in 30a0a03. When will my fix make it into a release? | Upcoming Releases |
|
I also verified that android e2e passes locally on my box. Let's see if we can re-enable android e2e on the CI :) |
vovkasm
pushed a commit
to vovkasm/react-native
that referenced
this pull request
Aug 7, 2019
Summary: Fixes broken ios/android e2e tests for CI. Changes: 1. Use `npm pack` instead of `yarn pack` during e2e test 2. Update test string assertions in ios/android e2e tests 3. Use `Step One` as candidate for source code replacement to test for page changes (since the "Welcome to React Native" string exists in the `Header` component instead of being on `App.js`) ## Changelog [Internal] [Fixed] - Fix ios/android e2e tests Pull Request resolved: facebook#24974 Differential Revision: D15431539 Pulled By: cpojer fbshipit-source-id: 054af2c2fff6bbdb2263c15d7f5cd416aaa507fd (cherry picked from commit 30a0a03)
M-i-k-e-l
pushed a commit
to M-i-k-e-l/react-native
that referenced
this pull request
Mar 10, 2020
Summary: Fixes broken ios/android e2e tests for CI. Changes: 1. Use `npm pack` instead of `yarn pack` during e2e test 2. Update test string assertions in ios/android e2e tests 3. Use `Step One` as candidate for source code replacement to test for page changes (since the "Welcome to React Native" string exists in the `Header` component instead of being on `App.js`) ## Changelog [Internal] [Fixed] - Fix ios/android e2e tests Pull Request resolved: facebook#24974 Differential Revision: D15431539 Pulled By: cpojer fbshipit-source-id: 054af2c2fff6bbdb2263c15d7f5cd416aaa507fd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes broken ios/android e2e tests for CI.
Changes:
npm packinstead ofyarn packduring e2e testStep Oneas candidate for source code replacement to test for page changes (since the "Welcome to React Native" string exists in theHeadercomponent instead of being onApp.js)Changelog
[Internal] [Fixed] - Fix ios/android e2e tests
Test Plan