Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TM] Add spec for Settings #24879

Closed
wants to merge 8 commits into from
Closed

[TM] Add spec for Settings #24879

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2b96e08
[TM] Add spec for Settings
ericlewis May 16, 2019
f60665e
use import + proper naming
ericlewis May 16, 2019
dd2f257
getConstants
ericlewis May 16, 2019
90ae277
fix type
ericlewis May 16, 2019
c3150ca
Fix error
ericlewis May 16, 2019
95434cf
Recursive.
ericlewis May 16, 2019
8248f27
simplify
ericlewis May 16, 2019
7f0cde1
Merge branch 'master' into spec-settings
ericlewis May 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Recursive.
  • Loading branch information
@ericlewis
ericlewis committed May 16, 2019
commit 95434cf71bdd1834f7f60bd7eb6444218487cb84
8 changes: 6 additions & 2 deletions Libraries/Settings/NativeSettingsManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,15 @@
import type {TurboModule} from 'RCTExport';
import * as TurboModuleRegistry from 'TurboModuleRegistry';

type Value = string | boolean | number | Object | Array<Value> | null;

export interface Spec extends TurboModule {
+getConstants: () => {|
settings: {[key: string]: string | boolean | number},
settings: {
[key: string]: Value,
},
|};
+setValues: (values: {+[key: string]: string | boolean | number}) => void;
+setValues: (values: {+[key: string]: Value}) => void;
+deleteValues: (values: Array<string>) => void;
}

Expand Down