Update Android view state when accessibility states are changed.

[marcmulcahy]

Summary

#24095 introduced a regression in an internal test case. Without access to the test case code, my best guess is that the test instantiates a button, and sets its "disabled" state to true. In the original code, when the button is rendered, if "disabled" is true, "disabled" is added to the accessibility states of the button, which causes the Android view's enabled state to be set to false.

In #24095, we removed the code that changes the underlying Android view's enabled state to false when "disabled" is included in the accessibility states, which seems correct. The Android view's state shouldn't mirror the accessibility state, it should be the other way round-- the accessibility state should represent the state of the view.

It seems that the existing test is brokenly setting the disabled state in the Javascript object, and then querying the Android view's enabled state to confirm the change. If the Button implementation is actually the culprit, then IMHO, the correct fix would be to have the Button implementation manipulate the Android View's enabled state, not the accessibilityStates code.

Changelog

[android] [fix] - Fix internal test case around disabled state of buttons

Test Plan

Verified that existing RNTester cases still work as expected.

[pull-bot]

Messages

📖

📋 Changelog Format - Did you include a Changelog? A changelog entry has the following format: [CATEGORY] [TYPE] - Message. CATEGORY may be: General iOS Android TYPE may be: Added, for new features. Changed, for changes in existing functionality. Deprecated, for soon-to-be removed features. Removed, for now removed features. Fixed, for any bug fixes. Security, in case of vulnerabilities. MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 8a3b7c4

[cpojer]

Awesome! Thank you for making this fix :)

[facebook-github-bot]

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by Marc Mulcahy in 70e2ab2.

^{When will my fix make it into a release? | Upcoming Releases}

[cpojer]

I can confirm that this fixed the test internally. Thank you so much!