Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove out-of-tree platform tests #24536

Closed
wants to merge 1 commit into from

Conversation

empyrical
Copy link
Contributor

Summary

This pull request removes the tests for out-of-tree platforms and the dependency on the package react-native-dummy from the React Native repo.

The logic that this was meant to test was moved to the React Native CLI repo, and it is being tested there as well making this a bit redundant at this point.

The dependency on react-native-dummy was also an issue, because when the file structure under Libraries/ changes, bundler errors could crop up if there wasn't an update made to the file structure of react-native-dummy/Libraries/.

This was an issue when TabBarIOS was removed - react-native-dummy was causing Haste errors and was stopping the commit from being able to land, and I needed to cut a new version just for it. With Lean Core, I expect more issues like this happening in the future.

Changelog

[General] [Removed] - Removed Out-of-Tree platform tests (functionality is tested in the RN-CLI repo now)

Test Plan

No regressions have been noted.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 19, 2019
@pull-bot
Copy link

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 1db4b2a

@empyrical empyrical marked this pull request as ready for review April 19, 2019 22:54
Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG this makes me so happy. Thank you.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @empyrical in b27d1d3.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Type: Removal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants