Remove out-of-tree platform tests #24536
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request removes the tests for out-of-tree platforms and the dependency on the package
react-native-dummy
from the React Native repo.The logic that this was meant to test was moved to the React Native CLI repo, and it is being tested there as well making this a bit redundant at this point.
The dependency on
react-native-dummy
was also an issue, because when the file structure underLibraries/
changes, bundler errors could crop up if there wasn't an update made to the file structure ofreact-native-dummy/Libraries/
.This was an issue when
TabBarIOS
was removed -react-native-dummy
was causing Haste errors and was stopping the commit from being able to land, and I needed to cut a new version just for it. With Lean Core, I expect more issues like this happening in the future.Changelog
[General] [Removed] - Removed Out-of-Tree platform tests (functionality is tested in the RN-CLI repo now)
Test Plan
No regressions have been noted.