-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update detox to 12.2.0 #24425
Update detox to 12.2.0 #24425
Conversation
@@ -147,7 +147,7 @@ | |||
"detox": { | |||
"test-runner": "jest", | |||
"runner-config": "RNTester/e2e/config.json", | |||
"specs": "RNTester/e2e", | |||
"specs": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be deleted since it's deprecated ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, that's what I first thought as well. However, for backwards-compatibility reasons, they suggest to keep the field set to an empty string. We can only remove it once the library gets updated to 13.0.0
I assume.
There is a whole section with additional information in the migration guide about it:
For the curious ones, who want to know more why we should use an empty string ("") instead of deleting "specs" [...]
a99de44
to
66714e6
Compare
5a2a6c2
to
88242af
Compare
Rebased and updated to |
88242af
to
a194bf0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This pull request was successfully merged by @friederbluemle in 62ff7d6. When will my fix make it into a release? | Upcoming Releases |
Summary
This updates
detox
from12.1.1
to12.2.0
.It includes (amongst other things) the following fixes, as described on the 12.1.4 release page:
It also updates the detox test script and config in
packages.json
(which was previously missed when detox was updated to 12.1.x). It will remove the following deprecation warnings:Instead of extra preprocessing the test folder by
detox
, it will now be passed straight tojest
.More information in the migration guide.
Changelog
[General] [Changed] - Update detox to 12.2.0
Test Plan
Successfully ran: