Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update detox to 12.2.0 #24425

Closed
wants to merge 1 commit into from

Conversation

friederbluemle
Copy link
Contributor

@friederbluemle friederbluemle commented Apr 12, 2019

Summary

This updates detox from 12.1.1 to 12.2.0.
It includes (amongst other things) the following fixes, as described on the 12.1.4 release page:

  • hotfix: redundant logs in the folder
  • fix: stabilize simulator log recording

It also updates the detox test script and config in packages.json (which was previously missed when detox was updated to 12.1.x). It will remove the following deprecation warnings:

detox[6416] WARN:  [test.js] Deprecation warning: "file" and "specs" support will be dropped in the next Detox version.
detox[6416] WARN:  [test.js] Please edit your package.json according to the migration guide: https://wix.to/I0DOAK0

Instead of extra preprocessing the test folder by detox, it will now be passed straight to jest.

More information in the migration guide.

Changelog

[General] [Changed] - Update detox to 12.2.0

Test Plan

Successfully ran:

yarn build-ios-e2e
yarn test-ios-e2e

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 12, 2019
@pull-bot
Copy link

pull-bot commented Apr 12, 2019

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against a194bf0

@@ -147,7 +147,7 @@
"detox": {
"test-runner": "jest",
"runner-config": "RNTester/e2e/config.json",
"specs": "RNTester/e2e",
"specs": "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be deleted since it's deprecated ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, that's what I first thought as well. However, for backwards-compatibility reasons, they suggest to keep the field set to an empty string. We can only remove it once the library gets updated to 13.0.0 I assume.

There is a whole section with additional information in the migration guide about it:

For the curious ones, who want to know more why we should use an empty string ("") instead of deleting "specs" [...]

@friederbluemle friederbluemle force-pushed the update-detox branch 2 times, most recently from a99de44 to 66714e6 Compare April 13, 2019 06:27
@friederbluemle friederbluemle changed the title Update detox to 12.1.4 Update detox to 12.2.0 Apr 13, 2019
@friederbluemle friederbluemle force-pushed the update-detox branch 3 times, most recently from 5a2a6c2 to 88242af Compare April 16, 2019 15:11
@friederbluemle friederbluemle changed the title Update detox to 12.2.0 Update detox to 12.3.0 Apr 16, 2019
@friederbluemle
Copy link
Contributor Author

Rebased and updated to 12.3.0.

@friederbluemle friederbluemle changed the title Update detox to 12.3.0 Update detox to 12.2.0 Apr 16, 2019
Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @friederbluemle in 62ff7d6.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants