Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Adjust template to match new init command #24138

Closed
wants to merge 5 commits into from
Closed

Improvement: Adjust template to match new init command #24138

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ff82ca5
Feature: new template
Esemesek Mar 25, 2019
070a7f5
Add config to package
Esemesek Mar 28, 2019
8ec132b
Bring back old template
Esemesek Apr 1, 2019
5b1753f
Add missing package.json
Esemesek Apr 1, 2019
70663d2
Change start command
Esemesek Apr 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add config to package
  • Loading branch information
@Esemesek
Esemesek committed Mar 28, 2019
commit 070a7f50b02f9e5de5fd9b47c1926777f950af23
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@
"README.md",
"third-party-podspecs",
"template",
"local-cli"
"local-cli",
"template.config.js"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you confirm with npm pack that .gitignore from template/is published as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not so relevant now, will matter for 3rd party templates though

],
"scripts": {
"start": "react-native start --reactNativePath .",
Expand Down