-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for utilities #23989
Add tests for utilities #23989
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, nice work! Thank you so much for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This pull request was successfully merged by @casperboone in f541c34. When will my fix make it into a release? | Upcoming Releases |
Summary
This PR add tests for several utilities in
Libraries/Utilities
, as a follow-up of #23903.The following utilities are now tested:
clamp.js
binareToBase64.js
DeviceInfo.js
mergeIntoFast.js
PixelRatio.js
infoLog.js
logError.js
warnOnce.js
mapWithSeparator
(added a missing test)Changelog
Not applicable, since it only adds tests.
Test Plan
This is a testing PR, so I do not believe that is necessary :)