[iOS] [Added] - Allow overriding ENTRY_FILE on react-native-xcode.sh script #23667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
Platform: iOS
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 27, 2019
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @brunolemos in 22b3528. When will my fix make it into a release? | Upcoming Releases |
react-native-bot
added
Merged
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 14, 2019
) Summary: - Using "System.getenv" allows to specify any entry file using environment variables and without modifying gradle file. Example: export ENTRY_FILE="another_entry_file.js" ./gradlew assembleDebug - This functionality is also more align with iOS implementation that uses 'if [[ "$ENTRY_FILE" ]]; then'. See #23667 for more details. - Possibility to define entry file on CI without modifying sources (Example: project like [pixels-catcher](https://www.npmjs.com/package/pixels-catcher) requires different entry file) ## Changelog: [Android] [Added] - Custom entry file on android using `ENTRY_FILE` environment variable Pull Request resolved: #26769 Test Plan: - Create a project from template - Define `ENTRY_FILE` environment variable ``` export ENTRY_FILE="anotherIndexFile.js" ``` - Build android ``` ./gradlew assembleDebug ``` Expected result: App contains bundle file that starts from `anotherIndexFile.js` file. Differential Revision: D17903165 Pulled By: cpojer fbshipit-source-id: 6b7cdf229918d101c170aa5fbdca6f3ef293d41c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Feature parity with Android, that already have this extensibility point on
build.gradle:react-native/react.gradle
Line 12 in 7c9805c
Helps with using react-native on a monorepo project (yarn workspaces) without having to use the no-hoist feature (e.g. in my case the
ENTRY_FILEis onroot/packages/mobile/index.jsinstead ofroot/index.ios.js)Changelog
[iOS] [Added] - Allow overriding ENTRY_FILE on react-native-xcode.sh script
Test Plan
I've been using this patch on DevHub for a few months now (https://github.com/devhubapp/devhub/search?q=ENTRY_FILE&unscoped_q=ENTRY_FILE).