Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a deprecation warning when importing NetInfo #23383

Closed
wants to merge 3 commits into from
Closed

Add a deprecation warning when importing NetInfo #23383

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a5b26de
Add a deprecation warning when importing NetInfo
matt-oakes Feb 11, 2019
e5fe86c
Update react-native-implementation.js
cpojer Feb 11, 2019
b808090
Update react-native-implementation.js
cpojer Feb 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Libraries/react-native/react-native-implementation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ module.exports = {
'webview-moved',
'WebView has been extracted from react-native core and will be removed in a future release. ' +
"It can now be installed and imported from 'react-native-webview' instead of 'react-native'. " +
'See https://github.com/react-native-community/react-native-webview for more informations.',
'See https://github.com/react-native-community/react-native-webview',
);
return require('WebView');
},
Expand Down Expand Up @@ -240,6 +240,12 @@ module.exports = {
return require('NativeEventEmitter');
},
get NetInfo() {
warnOnce(
'netinfo-moved',
'NetInfo has been extracted from react-native core and will be removed in a future release. ' +
"It can now be installed and imported from '@react-native-community/netinfo' instead of 'react-native'. " +
'See https://github.com/react-native-community/react-native-netinfo',
);
return require('NetInfo');
},
get PanResponder() {
Expand Down