Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Standalone for NativeComponents] RCTSlider #22998

Closed
wants to merge 1 commit into from
Closed

[Standalone for NativeComponents] RCTSlider #22998

wants to merge 1 commit into from
+16 −1

Conversation

OdaDaisuke
Copy link

Changelog:

[iOS] [Changed] - Deal with #22990. Move requireNativeComponent to a separate file.

Test Plan:

  • yarn test
  • yarn flow
  • yarn lint

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

analysis-bot
analysis-bot suggested changes Jan 15, 2019
View reviewed changes
Copy link

@analysis-bot analysis-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis results:

  • eslint found some issues.

Libraries/Components/Slider/RCTSliderNativeComponent.js

const requireNativeComponent = require('requireNativeComponent');

module.exports = requireNativeComponent('RCTSlider');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier/prettier: Insert ⏎

Libraries/Components/Slider/RCTSliderNativeComponent.js

const requireNativeComponent = require('requireNativeComponent');

module.exports = requireNativeComponent('RCTSlider');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eol-last: Newline required at end of file but not found.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 15, 2019
@OdaDaisuke
Copy link
Author

OdaDaisuke commented Jan 15, 2019 •
edited
Loading

I'll republish PullRequest after get CLA sign.

@OdaDaisuke OdaDaisuke closed this Jan 15, 2019
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@analysis-bot analysis-bot analysis-bot requested changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OdaDaisuke @facebook-github-bot @analysis-bot