Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
Author
|
Note: "test_ios" is expected to pass. |
Contributor
Author
|
Closing to test it on the "0.58-stable" branch first. |
Contributor
|
Thanks for updating these! How did your tests on 0.58 fare? |
hramos
added
the
Missing Changelog
Contributor
|
@grabbou what's your plan with this? |
Contributor
|
I'm in the process of updating the snapshots to include the filter control, but I have a blocker I've raised in Discord about tvOS RNTester not building. I'll need it to build so I can update the tvOS snapshots. |
Contributor
|
@grabbou is this active still? |
Contributor
Author
|
I think this PR should be closed. If I remember, the general conclusion was to regenerate the snapshots rather than adjusting the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes failing snapshot tests on iOS that were caused by bd79303
What it does is it hides newly introduced "filter" input when running snapshot tests.
It also fixes a glitch that happened when there was only one example to show (e.g. ART Example - missing RNTesterPage wrapper).
CC: @rickhanlonii @CodingItWrong