[CI] Propagate exit code in test_objc#22562
Closed
hramos wants to merge 1 commit intofacebook:masterfrom
Closed
Conversation
facebook-github-bot
added
CLA Signed
hramos
force-pushed
the
fix-test_objc
branch
3 times, most recently
from
503acd6 to
5f94daf
Compare
Member
|
LGTM |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Dec 10, 2018
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
grabbou
pushed a commit
that referenced
this pull request
Dec 17, 2018
Summary: Any failures in `test_objc` within the objc-test.sh script have been kept hidden as `xcpretty` was swallowing the exit code from xcodebuild. Fixes the issue TheSavior brought up in #22470 where failing snapshot tests were not reflected on Circle. Run on Circle CI and confirm `test_objc` fails (iOS tests *are* broken on master). Pull Request resolved: #22562 Differential Revision: D13406987 Pulled By: hramos fbshipit-source-id: 3f3da01ab4c0ad87077813b06d2fdf788f32f6b8
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: Any failures in `test_objc` within the objc-test.sh script have been kept hidden as `xcpretty` was swallowing the exit code from xcodebuild. Fixes the issue TheSavior brought up in facebook#22470 where failing snapshot tests were not reflected on Circle. Run on Circle CI and confirm `test_objc` fails (iOS tests *are* broken on master). Pull Request resolved: facebook#22562 Differential Revision: D13406987 Pulled By: hramos fbshipit-source-id: 3f3da01ab4c0ad87077813b06d2fdf788f32f6b8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any failures in
test_objcwithin the objc-test.sh script have been kept hidden asxcprettywas swallowing the exit code from xcodebuild.Fixes the issue @TheSavior brought up in #22470 where failing snapshot tests were not reflected on Circle.
Test Plan:
Run on Circle CI and confirm
test_objcfails (iOS tests are broken on master).