[flow-strict] Flow TouchableWithoutFeedback #22479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Generated by 🚫 dangerJS |
elicwhite
reviewed
Dec 3, 2018
| this.setState({ | ||
| toggleStatus: { | ||
| ...this.state.toggleStatus, | ||
| [refName]: !this.state.toggleStatus[refName], | ||
| [e]: !this.state.toggleStatus[e], |
There was a problem hiding this comment.
Well it "can", I didn't have time to run RNTester to test but at first glance this was a bit odd to me
There was a problem hiding this comment.
I believe it calls toString on Objects. So it is easily for multiple to conflict. Using a key or ID here would be better I think.
elicwhite
reviewed
Dec 3, 2018
exced
force-pushed
the
flowTouchableWithoutFeedback
branch
from
6710798
to
71efc22
Compare
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Dec 3, 2018
There was a problem hiding this comment.
@TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
hramos
removed
Import Started
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Jul 18, 2019
Summary: Related to #22100 Enhance TouchableWithoutFeedback with press and target event types. There are still work to do to update `UNSAFE_componentWillReceiveProps` and `touchableGetHitSlop` to make Flow not complain about `DeprecatedEdgeInsetsPropType` inexact type. Pull Request resolved: facebook/react-native#22479 Reviewed By: RSNara Differential Revision: D13310764 Pulled By: TheSavior fbshipit-source-id: 9002e542378491fb800c8e81c63f4fbe125b563c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #22100
Enhance TouchableWithoutFeedback with press and target event types.
There are still work to do to update
UNSAFE_componentWillReceivePropsandtouchableGetHitSlopto make Flow not complain aboutDeprecatedEdgeInsetsPropTypeinexact type.Test Plan:
Changelog:
[GENERAL] [ENHANCEMENT] [TouchableWithoutFeedback.js] - Flow types
[GENERAL] [ENHANCEMENT] [RTLExample.js] - Updating onPress callback