[flow-strict] Flow strict-local in TimePickerAndroid.android.js #22172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Generated by 🚫 dangerJS |
Contributor
Author
|
Hi @RSNara. Thanks for your review before. I've solved previously addvice, so Please check these changes. |
Contributor
Author
|
After this PR is merged, I'm ganna modify a relation file |
react-native-bot
added
🔶APIs
Flow
API: TimePickerAndroid
Platform: Android
RSNara
requested changes
Nov 6, 2018
Contributor
RSNara
left a comment
RSNara
left a comment
There was a problem hiding this comment.
I think you forgot to make these static properties read-only/covariant.
| static get timeSetAction() { | ||
| return 'timeSetAction'; | ||
| } | ||
| static timeSetAction = 'timeSetAction'; |
Contributor
There was a problem hiding this comment.
This static property should be covariant.
static +timeSetAction: string = 'timeSetAction';| static get dismissedAction() { | ||
| return 'dismissedAction'; | ||
| } | ||
| static dismissedAction = 'dismissedAction'; |
Contributor
There was a problem hiding this comment.
This static property should be covariant:
static +dismissedAction: string = 'dismissedAction';
Contributor
Author
Thanks for your review. I fixed it. |
7 tasks
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 21, 2018
Summary: Related to #22100 . I had this issue before(#22154 & #22172). Turn Flow strict mode on for Libraries/Components/TimePickerAndroid/TimePickerAndroid.android.js. - [x] npm run prettier - [x] npm run flow - [x] npm run flow-check-ios - [x] npm run flow-check-android - [x] npm run lint - [x] npm run test - [x] ./scripts/run-android-local-unit-tests.sh [GENERAL][ENHANCEMENT][TimePickerAndroid.android.js] - apply flow strict-local Pull Request resolved: #22188 Reviewed By: TheSavior Differential Revision: D12972356 Pulled By: RSNara fbshipit-source-id: 838604a791dfdc86bacf8b49f6c399920a3f57bc
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: Related to facebook#22100 . I had this issue before(facebook#22154 & facebook#22172). Turn Flow strict mode on for Libraries/Components/TimePickerAndroid/TimePickerAndroid.android.js. - [x] npm run prettier - [x] npm run flow - [x] npm run flow-check-ios - [x] npm run flow-check-android - [x] npm run lint - [x] npm run test - [x] ./scripts/run-android-local-unit-tests.sh [GENERAL][ENHANCEMENT][TimePickerAndroid.android.js] - apply flow strict-local Pull Request resolved: facebook#22188 Reviewed By: TheSavior Differential Revision: D12972356 Pulled By: RSNara fbshipit-source-id: 838604a791dfdc86bacf8b49f6c399920a3f57bc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #22100. I had this issue before(#22154).
Turn Flow strict mode on for Libraries/Components/TimePickerAndroid/TimePickerAndroid.android.js.
Test Plan:
Changelog:
[GENERAL][ENHANCEMENT][TimePickerAndroid.android.js] - apply flow strict-local