Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[createReactClass] remove createReactClass from TimerExample.js #21623

Closed
wants to merge 4 commits into from
Closed

[createReactClass] remove createReactClass from TimerExample.js #21623

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d12468c
Remove create-react-class and update props
peaonunes Oct 9, 2018
66a5b27
Use correct flow properties attribuition
peaonunes Oct 10, 2018
18ff98b
Remove unecessary life-cycle bind
peaonunes Oct 10, 2018
28a708f
Fix typo and prettier issues
peaonunes Oct 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 23 additions & 21 deletions RNTester/js/TimerExample.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
'use strict';

var React = require('react');
var createReactClass = require('create-react-class');
var ReactNative = require('react-native');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier/prettier: Delete ;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay 28a708f

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no-extra-semi: Unnecessary semicolon.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wat 28a708f

var {AlertIOS, Platform, ToastAndroid, Text, View} = ReactNative;
var RNTesterButton = require('./RNTesterButton');
Expand Down Expand Up @@ -117,26 +116,29 @@ class RequestIdleCallbackTester extends React.Component<{}, $FlowFixMeState> {
};
}

var TimerTester = createReactClass({
displayName: 'TimerTester',
type TimerTesterProps = $ReadOnly<{|
dt?: number,
type: string,
|}>;

_ii: 0,
_iters: 0,
_start: 0,
_timerId: (null: ?TimeoutID),
_rafId: (null: ?AnimationFrameID),
_intervalId: (null: ?IntervalID),
_immediateId: (null: ?Object),
_timerFn: (null: ?() => any),
class TimerTester extends React.Component<TimerTesterProps> {
_ii = 0;
_iters = 0;
_start = 0;
_timeId: ?TimeoutID = null;
_rafId: ?AnimationFrameID = null;
_intervalId: ?IntervalID = null;
_immediateId: ?Object = null;
_timerFn: ?() => any = null;

render: function() {
render() {
var args = 'fn' + (this.props.dt !== undefined ? ', ' + this.props.dt : '');
return (
<RNTesterButton onPress={this._run}>
Measure: {this.props.type}({args}) - {this._ii || 0}
</RNTesterButton>
);
},
};

componentWillUnmount() {
if (this._timerId != null) {
Expand All @@ -154,18 +156,18 @@ var TimerTester = createReactClass({
if (this._intervalId != null) {
clearInterval(this._intervalId);
}
},
};

_run: function() {
_run = () => {
if (!this._start) {
var d = new Date();
this._start = d.getTime();
this._iters = 100;
this._ii = 0;
if (this.props.type === 'setTimeout') {
if (this.props.dt < 1) {
if (this.props.dt !== undefined && this.props.dt < 1) {
this._iters = 5000;
} else if (this.props.dt > 20) {
} else if (this.props.dt !== undefined && this.props.dt > 20) {
this._iters = 10;
}
this._timerFn = () => {
Expand Down Expand Up @@ -220,18 +222,18 @@ var TimerTester = createReactClass({
if (this._timerFn) {
this._timerId = this._timerFn();
}
},
};

clear: function() {
clear = () => {
if (this._intervalId != null) {
clearInterval(this._intervalId);
// Configure things so we can do a final run to update UI and reset state.
this._intervalId = null;
this._iters = this._ii;
this._run();
}
},
});
};
}

exports.framework = 'React';
exports.title = 'Timers, TimerMixin';
Expand Down