RNTester: Remove all but one instance of PropTypes #21321
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
elicwhite
approved these changes
Sep 25, 2018
| </View> | ||
| <View style={styles.children}> | ||
| { | ||
| // $FlowFixMe found when converting React.createClass to ES6 |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Sep 25, 2018
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
@empyrical merged commit ae1817f into Once this commit is added to a release, you will see the corresponding version tag below the description at ae1817f. If the commit has a single |
hramos
removed
Import Started
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Apr 14, 2019
Summary: Part of: react-native-community/discussions-and-proposals#29 This PR removes all but one instance of PropTypes in `RNTester`. The last remaining conversion is `CameraRollView`, which I will do in a separate PR. Pull Request resolved: facebook/react-native#21321 Differential Revision: D10041809 Pulled By: TheSavior fbshipit-source-id: c03b1ce5ad640ae59ae6240a3b6c13581345b5a3
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: Part of: react-native-community/discussions-and-proposals#29 This PR removes all but one instance of PropTypes in `RNTester`. The last remaining conversion is `CameraRollView`, which I will do in a separate PR. Pull Request resolved: facebook#21321 Differential Revision: D10041809 Pulled By: TheSavior fbshipit-source-id: c03b1ce5ad640ae59ae6240a3b6c13581345b5a3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: react-native-community/discussions-and-proposals#29
This PR removes all but one instance of PropTypes in
RNTester. The last remaining conversion isCameraRollView, which I will do in a separate PR.Test Plan:
flow checkpassesRelease Notes:
Help reviewers and the release process by writing your own release notes. See below for an example.
[GENERAL] [ENHANCEMENT] [RNTester/js/LinkingExample.js] - Converted PropTypes to Flow
[GENERAL] [ENHANCEMENT] [RNTester/js/RNTesterBlock.js] - Removed PropTypes, cleaned up existing Flow types
[GENERAL] [ENHANCEMENT] [RNTester/js/RNTesterButton.js] - Removed PropTypes, cleaned up existing Flow types
[GENERAL] [ENHANCEMENT] [RNTester/js/RNTesterPage.js] - Removed PropTypes, cleaned up existing Flow types