Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Packager] Object.require should be ignored by Packager #2128

Closed
wants to merge 1 commit into from

Conversation

ptmt
Copy link
Contributor

@ptmt ptmt commented Jul 26, 2015

See #88.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jul 26, 2015
@ptmt
Copy link
Contributor Author

ptmt commented Jul 28, 2015

Tests has failed before because #2134.

@amasad
Copy link
Contributor

amasad commented Sep 8, 2015

Thanks for your contribution. We're in the process of moving the packager to it's own github repo and we'll be able to accept contributions like this much faster (we can just use the Github merge button). I'm hoping we can release it some time this week, and I'll ping you so we can move this PR there.

@ptmt
Copy link
Contributor Author

ptmt commented Sep 8, 2015

Thanks! I have some different pull requests for packager, but decided to
stop polluting issues.

On Tue, 8 Sep 2015 at 13:53, Amjad Masad notifications@github.com wrote:

Thanks for your contribution. We're in the process of moving the packager
to it's own github repo and we'll be able to accept contributions like this
much faster (we can just use the Github merge button). I'm hoping we can
release it some time this week, and I'll ping you so we can move this PR
there.


Reply to this email directly or view it on GitHub
#2128 (comment)
.

@ptmt ptmt closed this Nov 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants