-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] [BUGFIX] Fixing error when using RCTAnimation in Swift project using cocoapods #20964
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Generated by 🚫 dangerJS |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@react-linter I made this PR on top of the 0.57-stable because I would like this fixes to be on the new react native release it was around for such a long time and it needs to be fixed. |
@react-native-bot release note is available I think you missed it ;) |
@barrault01 we don't accept PRs on anything other than If we accepted PRs on stable branches, your changes would be limited to 0.57, and would not be available on 0.58, for example. |
Great it’s the last sed I’m doing on postinstall 🎉 Sent with GitHawk |
Hello,
When you try to install React Native with RCTAnimation dependency using Cocoapods on an existing swift project, it does not compile.
This PR fixed the problem explained in this issue :#13198.
The solution was already presented here: #13198 but never implemented.
Test Plan:
Clone this project that demonstrate the bug : https://github.com/barrault01/swift-reactnative.git
To fix the bug update the version of react-native on the package.json
Then run do this again on the root folder of the project:
And now the build will sucessed.
Release Notes:
[iOS] [BUGFIX] [Cocoapods integration] - now using RCTAnimation subspecs does not make the build failed on iOS when integrated React Native using Cocoapods.