Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] [BUGFIX] Fixing error when using RCTAnimation in Swift project using cocoapods #20964

Closed
wants to merge 1 commit into from

Conversation

barrault01
Copy link

Hello,

When you try to install React Native with RCTAnimation dependency using Cocoapods on an existing swift project, it does not compile.

This PR fixed the problem explained in this issue :#13198.

The solution was already presented here: #13198 but never implemented.

Test Plan:

Clone this project that demonstrate the bug : https://github.com/barrault01/swift-reactnative.git

git clone https://github.com/barrault01/swift-reactnative.git
yarn install
cd ios
pod install
open ReatNativeSwift.xcworkspace 

To fix the bug update the version of react-native on the package.json

{
  "name": "MyReactNativeApp",
  "version": "0.0.1",
  "private": true,
  "scripts": {
    "start": "node node_modules/react-native/local-cli/cli.js start"
  },
  "dependencies": {
    "react": "16.4.1",
    "react-native": "git://github.com/barrault01/react-native.git#70f7e5ea9ed226604d795b6646f14a8192b860fb"
  }
}

Then run do this again on the root folder of the project:

yarn install
cd ios
pod install
open ReatNativeSwift.xcworkspace 

And now the build will sucessed.

Release Notes:

[iOS] [BUGFIX] [Cocoapods integration] - now using RCTAnimation subspecs does not make the build failed on iOS when integrated React Native using Cocoapods.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@pull-bot
Copy link

pull-bot commented Sep 4, 2018

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Generated by 🚫 dangerJS

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 4, 2018
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@react-native-bot react-native-bot added Platform: iOS iOS applications. ✅Test Plan Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. labels Sep 4, 2018
@barrault01
Copy link
Author

@react-linter I made this PR on top of the 0.57-stable because I would like this fixes to be on the new react native release it was around for such a long time and it needs to be fixed.

@barrault01
Copy link
Author

@react-native-bot release note is available I think you missed it ;)

@hramos
Copy link
Contributor

hramos commented Sep 5, 2018

@barrault01 we don't accept PRs on anything other than master. Once a change lands on master, you can comment on react-native-community/releases#34 to request your changes be cherry-picked onto 0.57.

If we accepted PRs on stable branches, your changes would be limited to 0.57, and would not be available on 0.58, for example.

@hramos hramos added ✅Release Notes and removed Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. labels Sep 5, 2018
@barrault01 barrault01 changed the base branch from 0.57-stable to master September 5, 2018 19:01
@barrault01 barrault01 changed the base branch from master to 0.57-stable September 5, 2018 19:01
@Titozzz
Copy link
Collaborator

Titozzz commented Sep 5, 2018

Great it’s the last sed I’m doing on postinstall 🎉

Sent with GitHawk

@barrault01
Copy link
Author

barrault01 commented Sep 6, 2018

@hramos Thanks for the clarification, I reopened the PR #20963 can you give it a look?

@barrault01 barrault01 closed this Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Platform: iOS iOS applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants