bump android target version to 27 #20843
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
✅Test Plan
Missing Changelog
gengjiawen
changed the title
gengjiawen
added
✅Release Notes
and removed
Missing Changelog
|
I left it intentionally to have sometime to make sure that RN works without issues. I would recommend to bump it after few stable releases, since Google doesn't require it. |
|
Please edit buckconfig and ReactAndroid build.gradle to target 27 👍 |
|
|
gengjiawen
requested review from
grabbou,
janicduplessis,
Kureev,
mhorowitz and
shergin
as code owners
|
@gengjiawen oops |
gengjiawen
force-pushed
the
feature/bump_target_sdk
branch
from
1207bfd to
41f9ba2
Compare
|
@dulmandakh Fixed the wrong rebase, and bump target sdk version to 27. |
|
@facebook-github-bot shipit |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Sep 15, 2018
There was a problem hiding this comment.
dulmandakh is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@gengjiawen merged commit 4f49404 into Once this commit is added to a release, you will see the corresponding version tag below the description at 4f49404. If the commit has a single |
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: bump target version to 27 pass all current ci. none [GENERAL] [ANDROID] [FEATURE] - bump android target version to 27 Pull Request resolved: facebook/react-native#20843 Differential Revision: D9845999 Pulled By: hramos fbshipit-source-id: 3c532a2d5a2b7d201bacab54cf3d60e1efffb653
hramos
removed
Import Started
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Apr 14, 2019
Summary: bump target version to 27 pass all current ci. none [GENERAL] [ANDROID] [FEATURE] - bump android target version to 27 Pull Request resolved: facebook/react-native#20843 Differential Revision: D9845999 Pulled By: hramos fbshipit-source-id: 3c532a2d5a2b7d201bacab54cf3d60e1efffb653
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: bump target version to 27 pass all current ci. none [GENERAL] [ANDROID] [FEATURE] - bump android target version to 27 Pull Request resolved: facebook#20843 Differential Revision: D9845999 Pulled By: hramos fbshipit-source-id: 3c532a2d5a2b7d201bacab54cf3d60e1efffb653
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
bump target version to 27
Test Plan
pass all current ci.
Related PRs
none
Release Notes
[GENERAL] [ANDROID] [FEATURE] - bump android target version to 27