Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression in dynamic resolution for out-of-tree platforms #20662

Closed
wants to merge 15 commits into from
Closed

Fix regression in dynamic resolution for out-of-tree platforms #20662

wants to merge 15 commits into from

Commits on Aug 14, 2018

  1. Initial changes to make platform resolution dynamic for out-of-tree p… 

    …latform plugins. Unrelated style auto-fixes to get lint and prettier to pass. Next step is to add more tests that illustrate further regressions for this functionality.
    @matthargett
    matthargett committed Aug 14, 2018
    Configuration menu
    Copy the full SHA
    d314ef8 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2018

  1. Merge branch 'master' of github.com:matthargett/react-native into dyn… 

    …amic-platforms
    @matthargett
    matthargett committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    94425cc View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2018

  1. Revert fixes for lint/prettier failures.

    @matthargett
    matthargett committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    a5190b7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:facebook/react-native into dynami… 

    …c-platforms
    @matthargett
    matthargett committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    a51bffe View commit details
    Browse the repository at this point in the history

  3. Take Name.es6.js and Name.es7.js into account for regexp.

    @matthargett
    matthargett committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    771df00 View commit details
    Browse the repository at this point in the history

  4. Revert prettier auto-fix.

    @matthargett
    matthargett committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    403930c View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2018

  1. Adjust comment and regexp. Note weird error when only two platforms a… 

    …re in the getPlatforms() list.
    @matthargett
    matthargett committed Aug 17, 2018
    Configuration menu
    Copy the full SHA
    1f7f362 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2018

  1. From @rozele: React Native overrides the settings for, e.g., , which … 

    …prevents us from adding a file to the repo for out-of-tree platforms that allows us to resolve Haste modules at the top-level of the repo. This change ensures that if a user has a file, those settings are not overwritten by React Native.
    @matthargett
    matthargett committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    8dc4fe7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:facebook/react-native into dynami… 

    …c-platforms
    @matthargett
    matthargett committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    9edfa98 View commit details
    Browse the repository at this point in the history

  3. Remove hard-coded platform paths.

    @matthargett
    matthargett committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    5207cd1 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2018

  1. hasteImpl will be overridden via metro configurations of out-of-tree … 

    …platforms
    @matthargett
    matthargett committed Aug 23, 2018
    Configuration menu
    Copy the full SHA
    0e72049 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:facebook/react-native into dynami… 

    …c-platforms
    @matthargett
    matthargett committed Aug 23, 2018
    Configuration menu
    Copy the full SHA
    3159e0c View commit details
    Browse the repository at this point in the history

  3. Update tests to remove out-of-tree platform specifics

    @matthargett
    matthargett committed Aug 23, 2018
    Configuration menu
    Copy the full SHA
    d366ea4 View commit details
    Browse the repository at this point in the history

  4. Fix comment

    @matthargett
    matthargett committed Aug 23, 2018
    Configuration menu
    Copy the full SHA
    9ce4e7a View commit details
    Browse the repository at this point in the history

  5. My synthetic tests didn't capture real-world pathing. This should fix… 

    … the problem reported.
    @matthargett
    matthargett committed Aug 23, 2018
    Configuration menu
    Copy the full SHA
    5733fe1 View commit details
    Browse the repository at this point in the history