Properly escape JavaScript code on Android#20366
Closed
LinusU wants to merge 1 commit intofacebook:masterfrom
Closed
Properly escape JavaScript code on Android#20366LinusU wants to merge 1 commit intofacebook:masterfrom
LinusU wants to merge 1 commit intofacebook:masterfrom
Conversation
facebook-github-bot
added
the
CLA Signed
LinusU
force-pushed
the
escape-javascript
branch
from
9c06232 to
77a229a
Compare
Contributor
Author
|
Rebased on |
LinusU
force-pushed
the
escape-javascript
branch
from
77a229a to
feeab42
Compare
Contributor
Author
rebasing again to restart the test... |
LinusU
force-pushed
the
escape-javascript
branch
from
feeab42 to
231be62
Compare
LinusU
referenced
this pull request
Aug 1, 2018
Summary: Pull Request resolved: #20178 Differential Revision: D8860733 Pulled By: TheSavior fbshipit-source-id: ec4aa3050755652106dec9ea245394314c862e97
LinusU
force-pushed
the
escape-javascript
branch
from
231be62 to
826afaa
Compare
Contributor
Author
|
Seems like master fails CI for code style... |
LinusU
force-pushed
the
escape-javascript
branch
from
826afaa to
c00bc80
Compare
Contributor
Author
|
ping @mdvacca, seems like you have been touching this part of the code before, any chance of getting this merged? |
LinusU
force-pushed
the
escape-javascript
branch
from
c00bc80 to
9c95db2
Compare
Contributor
Author
|
Rebased on master again but now the test is failing on something that seems related to iOS, and this PR only touches Android 🤔 |
facebook-github-bot
added
the
Import Started
Contributor
|
Thanks for the PR! |
facebook-github-bot
approved these changes
Aug 9, 2018
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
This pull request was closed by @LinusU in e6b305b. Once this commit is added to a release, you will see the corresponding version tag below the description at e6b305b. If the commit has a single |
kelset
pushed a commit
that referenced
this pull request
Aug 13, 2018
Summary: These changes will fix executing javascript with any special characters, by making use of the `evaluateJavascript` function on Android 4.4+, and by properly escaping the URI on Android <4.4. Fixes #19611 • Fixes #20365 • Fixes #9749 • Closes #19655 • Closes #12321 This PR supersedes #19655 by patching the same problem in all the places, and fixing it for Android <4.4 as well. Pull Request resolved: #20366 Differential Revision: D9242968 Pulled By: hramos fbshipit-source-id: f2e1abc786ba333dbd8aaa8922e716fd99ec26e0
hramos
removed
Import Started
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes will fix executing javascript with any special characters, by making use of the
evaluateJavascriptfunction on Android 4.4+, and by properly escaping the URI on Android <4.4.Fixes #19611 • Fixes #20365 • Fixes #9749 • Closes #19655 • Closes #12321
This PR supersedes #19655 by patching the same problem in all the places, and fixing it for Android <4.4 as well.
Test Plan:
The snack from #20365 should now work on Android as it does on iOS. That is, it should show "12" three times.
https://snack.expo.io/rkSxWhNVm
It can also be tested by instantiating a
WebViewwithinjectedJavaScriptset todocument.write('1')\ndocument.write('2')and observe that "12" is written in the WebView.Release Notes:
[ANDROID] [BUGFIX] [WebView] - Properly escape JavaScript code