Conversation
0a4c4d6 to
17f9aa6
Compare
|
Can you add a couple more lines in the PR description explaining which error you were seeing? I guess we will also have to "counter-check" that that change in the ignore doesn't break builds on macOS (or the CI already "takes care" of that?). Do you have any external references about the Windows bug, I mean, is it like a known bug on Windows that requires to make that change in the |
|
@kelset I add full error info in motivation. This is a bug only windows, so unix-like system works just as I tested. Related gradle bug: gradle/gradle#4663. |
|
With this pr and #19974, all build issue on windows should be resolved. |
|
Understood. |
|
@hramos Can you review this pr ? Thanks. |
|
@hramos This fix will greatly help windows user to test RNTester like me. Can you review this ? Thanks. |
facebook-github-bot
left a comment
There was a problem hiding this comment.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was closed by @gengjiawen in 847261b. Once this commit is added to a release, you will see the corresponding version tag below the description at 847261b. If the commit has a single |
Summary: fix windows gradle bug, you can also see full log in https://ci.appveyor.com/project/gengjiawen/react-native/build/1.0.11/job/ic0nml8s4qbmni4e. ``` FAILURE: Build failed with an exception. * What went wrong: Failed to capture snapshot of input files for task ':RNTester:android:app:bundleReleaseJsAndAssets' property '$1' during up-to-date check. > Failed to create MD5 hash for file content. * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights. * Get more help at https://help.gradle.org ``` Build success log: https://ci.appveyor.com/project/gengjiawen/react-native/build/1.0.12/job/xuaj8tm3p1piovbt. pass all current ci. facebook/react-native#20281 [GENERAL] [INTERNAL] [RNTester] - fix windows gradle bug Pull Request resolved: facebook/react-native#20293 Differential Revision: D9071261 Pulled By: hramos fbshipit-source-id: 87fab94d15d78dac1db51f15ca5f4ea9e3a6ad04
Motivation
fix windows gradle bug, you can also see full log in https://ci.appveyor.com/project/gengjiawen/react-native/build/1.0.11/job/ic0nml8s4qbmni4e.
Build success log: https://ci.appveyor.com/project/gengjiawen/react-native/build/1.0.12/job/xuaj8tm3p1piovbt.
Test Plan
pass all current ci.
Related PRs
#20281
Release Notes
[GENERAL] [INTERNAL] [RNTester] - fix windows gradle bug