Improve docker #19354
Closed
Improve docker #19354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
react-native-bot
added
✅Test Plan
Type: Enhancement
facebook-github-bot
added
the
CLA Signed
|
@hramos Can you review this, thanks. |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
May 24, 2018
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
macdoum1
pushed a commit
to macdoum1/react-native
that referenced
this pull request
Jun 28, 2018
Summary: Improve current docker by * Make android build version and tools version config easily, and bump them to 26. * use less file layer * fix current docker error (the maintainer line) * fix typo in package.json Since ci on master branch still failed, and I run test the docker build. And in the process I found buck related config still is 23. none [GENERAL] [ENHANCEMENT] [CI] - Improve docker Closes facebook#19354 Differential Revision: D8148376 Pulled By: hramos fbshipit-source-id: 8f965860487467c1a219e64588ff3000d571ddc1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improve current docker by
Test Plan
Since ci on master branch still failed, and I run test the docker build. And in the process I found buck related config still is 23.
Related PRs
none
Release Notes
[GENERAL] [ENHANCEMENT] [CI] - Improve docker