Skip to content

Adds scrollToInterval to vertical scrollviews in React Native 0.51 #18679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

PimDeWitte
Copy link

@PimDeWitte PimDeWitte commented Apr 3, 2018

Thank you for sending the PR! We appreciate you spending the time to work on these changes.
Help us understand your motivation by explaining why you decided to make this change.

Fixes #11020

This PR adds vertical scrollview scollToInterval so you can have a snapping experience on vertical scroll cards on Android. There was already support for horizontal snapToInterval, this simply adds the vertical version.

Test Plan

Verified that it works on a production app that has been in production on android for nearly half a year and has not had any issues with it. Also, here is a video:

https://drive.google.com/file/u/2/d/129zFXzpAOBlGC3cgPVGUJtvWdasfyjC-/view?usp=drivesdk

Related PRs

It should make documentation more cohesive since the fact that scrollToInterval doesn't work wasn't documented when I last checked

Release Notes

[ANDROID] [FEATURE] [ScollView] - scrollToInterval added to vertical scrollview

@janicduplessis
Copy link
Contributor

Sadly we don't accept PRs to other branches than master on this repo, if you want to request a cherry pick into a past release you can post in the corresponding issue on this repo https://github.com/react-native-community/react-native-releases/issues. We don't go as far as 0.51 thought so I suggest updating to the latest stable version.

@geolabZura
Copy link

Hello,
How can I use this new feature to make swiping scroll on Android?
I can't find enough information about ScrollToInterval in Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants