-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fishhook import #17080
Fix fishhook import #17080
Conversation
@facebook-github-bot label Needs more information Generated by 🚫 dangerJS |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@facebook-github-bot duplicate #16271 |
@dgyesbreghs I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
This should probably be solved using this approach: #13198 (comment) |
closing as a duplicate of #16271 |
Motivation
We were getting a 'file not found' error, when we tried to integrate React Native through CocoaPods.
Screenshot
Removing the first part of the import has fixed the import statement. Let Xcode found the correct location/file.
Test Plan
npm install
file not found
error.RCTReconnectingWebSocket.m
file.Build Successful
message.Or you can watch the video below.
Video
Release Notes
[IOS][BUGFIX] - Make sure you can use React Native through CocoaPods