Add logic to show style props in docs #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Can you split this into two pull requests. One for the website that you can merge directly (or push it). And one for the lib code that you can either do a pull request here or send an internal diff. Thanks! |
|
Sure! |
| @@ -11,21 +11,19 @@ var ReactPropTypes = require('ReactPropTypes'); | |||
|
|
|||
| var merge = require('merge'); | |||
|
Your internals changes have landed on github, you should be able to push the rest :) |
|
I made changes to also link |
fkling
added a commit
that referenced
this pull request
Mar 23, 2015
Add logic to show style props in docs
harrykiselev
pushed a commit
to harrykiselev/react-native
that referenced
this pull request
Aug 5, 2015
Website build is broken
acoates-ms
pushed a commit
to acoates-ms/react-native
that referenced
this pull request
Oct 8, 2019
ayushjainrksh
referenced
this pull request
in MLH-Fellowship/react-native
Jul 2, 2020
* Add missing method presentLocalNotification * Fix broken link
react-one
pushed a commit
to react-one/react-native
that referenced
this pull request
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still missing linking
styleprops that are defined asstyle: Text.propTypes.styleto the correct prop (i.e.Text#stylein this case). This could also be done in the documentation parser btw (instead of the frontend).I'm currently reusing the
Componentlayout for theLayoutPropTypespage.