Give complex FlatList example more motivation #14957
Conversation
Previously, the example MyListItem never referenced the selected prop, leaving ambiguity about the intention of the demo. By adding a concrete implementation with coloring based on the selected prop, we can see that this is a demo of a multi-select list for batch actions instead of, say, a click-to-navigate nested list. Here is a working Snack demo for future reference: https://snack.expo.io/BkRMRTGB- References facebook#14872
facebook-github-bot
added
GH Review: review-needed
CLA Signed
taylorkline
force-pushed
the
flatlist-doc-patch
branch
from
1019156 to
c04e7e4
Compare
|
@jkdf2 I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
|
Hey sorry missed your last update - feel free to ping me next time. Hopefully it still merges cleanly :) |
facebook-github-bot
added
GH Review: accepted
Import Started
|
@sahrens has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Previously, the example MyListItem never referenced the selected prop, leaving ambiguity about the intention of the demo.
By adding a concrete implementation with coloring based on the selected prop, we can see that this is a demo of a multi-select list for batch actions instead of, say, a click-to-navigate nested list.
Here is a working Snack demo for future reference:
https://snack.expo.io/BkRMRTGB-
References #14872