[ci] Upgrade the version of Yarn to 0.27.5 for CI #14883
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
Any reason we shouldn't use the latest release of yarn always (e.g. |
The TravisCI tests were using an especially old version of Yarn. Upgrade to use the latest so we're using a version closer to the version that more people (and especially RN maintainers) would be using. Kept the Docker Yarn version static since people run that on their own machines and being more reproducible and static is helpful (vs CI that we can quickly react to). Test plan: Look at the OSS CI tests; make sure there are no Yarn / node_module errors.
|
@javache Nice suggestion, let's give it a try. I kept the Yarn version in the Docker setup static because I think it's intended for people to run it on their own machines, and erring on the side of having fewer moving parts is more helpful in that context I think. |
|
Travis E2E tests pass so I think this worked, I don't see any Yarn-related errors. |
facebook-github-bot
added
GH Review: accepted
Import Started
|
@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TravisCI tests were using an especially old version of Yarn. Upgrade to 0.27.5 so we're using a version closer to the version that more people (and especially RN maintainers) would be using.
Test plan: Look at the OSS CI tests; make sure there are no Yarn / node_module errors.