Skip to content

Fixing another iOS app extension unsafe API usage in react native #13328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Fixing another iOS app extension unsafe API usage in react native #13328

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
49696e3
v1 of replacing all instances of [UIApplication sharedApplication] wi…
shrutic Mar 30, 2017
ca85b50
Merge branch 'master' of git://github.com/facebook/react-native
shrutic Mar 31, 2017
0435c87
Merge commit '9075fe06189a5d0cf237b1118bc8437d92968fd0'
shrutic Mar 31, 2017
7e472d6
Include the header files to get access to definition of RCTSharedAppl…
shrutic Mar 31, 2017
6f28b2c
Remove extraneous bracket
shrutic Mar 31, 2017
2804409
Merge commit 'c7387fefc85fd15dceadfa291857099ed3e848b8'
shrutic Apr 5, 2017
5aeee93
Update the usage of the UIAlertView with UIAlertViewController
shrutic Apr 5, 2017
8a20def
Merge commit '269458c613b658a0a3e8e7e86f8394278d5b9e23'
shrutic Apr 5, 2017
0fc2599
Merge commit 'cd4545f812d0c1404dcc9ce2982babd009f188f9'
shrutic Apr 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions React/Profiler/RCTProfile.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -772,11 +772,14 @@ void RCTProfileSendResult(RCTBridge *bridge, NSString *route, NSData *data)
if (message.length) {
#if !TARGET_OS_TV
dispatch_async(dispatch_get_main_queue(), ^{
[[[UIAlertView alloc] initWithTitle:@"Profile"
message:message
delegate:nil
cancelButtonTitle:@"OK"
otherButtonTitles:nil] show];
UIAlertController *alertController = [UIAlertController
alertControllerWithTitle:@"Profile"
message:message
preferredStyle:UIAlertControllerStyleAlert];
[alertController addAction:[UIAlertAction actionWithTitle:@"OK"
style:UIAlertActionStyleCancel
handler:nil]];
[RCTPresentedViewController() presentViewController:alertController animated:YES completion:nil];
});
#endif
}
Expand Down