Native Animated: Prevent views driven by native animated from being optimized away #12983
Conversation
facebook-github-bot
added
CLA Signed
facebook-github-bot
added
GH Review: accepted
Import Started
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
facebook-github-bot
added
Import Failed
Import Started
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1 similar comment
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@hramos Could you try shipping this again? |
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1 similar comment
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
The original import failed due to some changes we made to our internal repository. This last one should import successfully. |
|
Landing again. |
|
@ericnakagawa has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
still failed? |
|
@hramos @ericnakagawa Could you try shipping this again? |
|
Some internal snapshot tests need to be updated for this to be able to land. |
…ptimized away Summary: When using native animated we don't go through the shadow thread and use the NativeViewHierachyOptimizer so we have to make sure the views won't get optimized away. Also since we are not passing certain props because they are driven by native it is possible that the view will be marked as layout only when in fact it is not. **Test plan** Animated a simple view that will be collapsed with native animated and reproduce the error (it's actually just an error log in logcat now and no longer a redscreen) and checked that this fixes it. Fixes facebook#12975 Closes facebook#12983 Differential Revision: D4811420 Pulled By: javache fbshipit-source-id: f217f244baca64df2b76cbe08cce2d847c0dc985
When using native animated we don't go through the shadow thread and use the NativeViewHierachyOptimizer so we have to make sure the views won't get optimized away. Also since we are not passing certain props because they are driven by native it is possible that the view will be marked as layout only when in fact it is not.
Test plan
Animated a simple view that will be collapsed with native animated and reproduce the error (it's actually just an error log in logcat now and no longer a redscreen) and checked that this fixes it.
Fixes #12975