Skip to content

Animated - Add missing super calls to fix native animated crash #12910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Animated - Add missing super calls to fix native animated crash #12910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a1f894
Animated - Add missing super calls to fix native animated crash
janicduplessis Mar 13, 2017
6786674
Fix test
janicduplessis Mar 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Libraries/Animated/src/AnimatedImplementation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1328,6 +1328,7 @@ class AnimatedModulo extends AnimatedWithChildren {

__detach(): void {
this._a.__removeChild(this);
super.__detach();
}

__getNativeConfig(): any {
Expand Down Expand Up @@ -1378,6 +1379,7 @@ class AnimatedDiffClamp extends AnimatedWithChildren {

__detach(): void {
this._a.__removeChild(this);
super.__detach();
}

__getNativeConfig(): any {
Expand Down Expand Up @@ -1461,6 +1463,7 @@ class AnimatedTransform extends AnimatedWithChildren {
}
}
});
super.__detach();
}

__getNativeConfig(): any {
Expand Down Expand Up @@ -1568,6 +1571,7 @@ class AnimatedStyle extends AnimatedWithChildren {
value.__removeChild(this);
}
}
super.__detach();
}

__makeNative() {
Expand Down
2 changes: 1 addition & 1 deletion Libraries/Animated/src/__tests__/AnimatedNative-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ describe('Native Animated', () => {
);

expect(nativeAnimatedModule.disconnectAnimatedNodes).toHaveBeenCalledTimes(2);
expect(nativeAnimatedModule.dropAnimatedNode).toHaveBeenCalledTimes(2);
expect(nativeAnimatedModule.dropAnimatedNode).toHaveBeenCalledTimes(3);
});

it('sends a valid description for value, style and props nodes', () => {
Expand Down