[uglify-js] Lock version to 2.7.5 to avoid breakage like #12772 #12802
Conversation
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
I'd suggest using |
brentvatne
changed the title
|
👍 This not being hardcoded has now caused me pain twice! (Less pain the second time, thank god) TO THE TOP WITH YOU! 🚀 |
facebook-github-bot
added
GH Review: accepted
Import Started
|
@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
facebook-github-bot
added
Import Failed
and removed
Import Started
Summary: As per uglify-js maintainer kzc's comment in mishoo/UglifyJS#1573 (comment) we should be locking our version to prevent issues like #12772 from happening again. No test plan needed, people are already using this version of uglify-js (it's the latest). Closes facebook/react-native#12802 Differential Revision: D4749853 Pulled By: javache fbshipit-source-id: 866a19cb2c1add31b55e14d0f4dadb7f68fda64c
As per uglify-js maintainer @kzc's comment in mishoo/UglifyJS#1573 (comment) we should be locking our version to prevent issues like #12772 from happening again.
No test plan needed, people are already using this version of uglify-js (it's the latest).