Match on s.version only
#12381
Match on s.version only
#12381
Conversation
Recent PR by @alloy adds `s.cocoapods_version`. That makes `release script` also modify that value. Adding `\` makes `sed` match on a dot character (I believe missing `\` was a mistake). Used and tested here: https://github.com/facebook/react-native/commits/0.42-stable
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
@bestander has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
facebook-github-bot
added
Import Failed
and removed
Import Started
|
@bestander any ideas why this would break something internally? Looks like a fix for a recently introduced change. |
|
Definitely it did not break anything, some infra issue prevented a land. |
facebook-github-bot
added
the
Import Started
|
@bestander has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
removed
the
Import Started
|
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
facebook-github-bot
added
the
Import Started
|
@bestander has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@zpao has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Recent PR by alloy adds `s.cocoapods_version`. That makes `release script` also modify that value. Adding `\` makes `sed` match on a dot character (I believe missing `\` was a mistake). Used and tested here: https://github.com/facebook/react-native/commits/0.42-stable CC bestander Closes facebook#12381 Differential Revision: D4558370 Pulled By: bestander fbshipit-source-id: 3bee7bac3002c0c83c100ce9d0c67463e030a428
Summary: Recent PR by alloy adds `s.cocoapods_version`. That makes `release script` also modify that value. Adding `\` makes `sed` match on a dot character (I believe missing `\` was a mistake). Used and tested here: https://github.com/facebook/react-native/commits/0.42-stable CC bestander Closes facebook#12381 Differential Revision: D4558370 Pulled By: bestander fbshipit-source-id: 3bee7bac3002c0c83c100ce9d0c67463e030a428
Recent PR by @alloy adds
s.cocoapods_version. That makesrelease scriptalso modify that value. Adding\makessedmatch on a dot character (I believe missing\was a mistake).Used and tested here: https://github.com/facebook/react-native/commits/0.42-stable
CC @bestander