Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for Text allowFontScaling #11993

Closed
wants to merge 2 commits into from

Conversation

hawkrives
Copy link
Contributor

Explain the motivation for making this change. What existing problem does the pull request solve?

The documentation was slightly out of date. Following #10898, which removed the @platform ios tag, this updates the inner documentation to remove the reference to iOS.

Remove the inner note that says that it only applies to iOS.
@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Jan 19, 2017
@facebook-github-bot
Copy link
Contributor

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added Import Failed and removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Jan 21, 2017
@facebook-github-bot
Copy link
Contributor

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Jan 23, 2017
@facebook-github-bot
Copy link
Contributor

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

@facebook-github-bot facebook-github-bot removed the Import Started This pull request has been imported. This does not imply the PR has been approved. label Jan 24, 2017
@mkonicek
Copy link
Contributor

Thanks!

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Jan 30, 2017
@facebook-github-bot
Copy link
Contributor

@mkonicek has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@hawkrives hawkrives deleted the patch-2 branch January 30, 2017 21:02
edmofro pushed a commit to edmofro/react-native that referenced this pull request Feb 6, 2017
Summary:
> Explain the **motivation** for making this change. What existing problem does the pull request solve?

The documentation was slightly out of date. Following facebook#10898, which removed the `platform ios` tag, this updates the inner documentation to remove the reference to iOS.
Closes facebook#11993

Differential Revision: D4443723

Pulled By: hramos

fbshipit-source-id: b859c9b0fe1f5e564b919663f8c75401a52ffc9f
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 7, 2017
Summary:
> Explain the **motivation** for making this change. What existing problem does the pull request solve?

The documentation was slightly out of date. Following facebook#10898, which removed the `platform ios` tag, this updates the inner documentation to remove the reference to iOS.
Closes facebook#11993

Differential Revision: D4443723

Pulled By: hramos

fbshipit-source-id: b859c9b0fe1f5e564b919663f8c75401a52ffc9f
normanjoyner pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
Summary:
> Explain the **motivation** for making this change. What existing problem does the pull request solve?

The documentation was slightly out of date. Following facebook#10898, which removed the `platform ios` tag, this updates the inner documentation to remove the reference to iOS.
Closes facebook#11993

Differential Revision: D4443723

Pulled By: hramos

fbshipit-source-id: b859c9b0fe1f5e564b919663f8c75401a52ffc9f
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
Summary:
> Explain the **motivation** for making this change. What existing problem does the pull request solve?

The documentation was slightly out of date. Following facebook#10898, which removed the `platform ios` tag, this updates the inner documentation to remove the reference to iOS.
Closes facebook#11993

Differential Revision: D4443723

Pulled By: hramos

fbshipit-source-id: b859c9b0fe1f5e564b919663f8c75401a52ffc9f
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
Summary:
> Explain the **motivation** for making this change. What existing problem does the pull request solve?

The documentation was slightly out of date. Following facebook#10898, which removed the `platform ios` tag, this updates the inner documentation to remove the reference to iOS.
Closes facebook#11993

Differential Revision: D4443723

Pulled By: hramos

fbshipit-source-id: b859c9b0fe1f5e564b919663f8c75401a52ffc9f
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
Summary:
> Explain the **motivation** for making this change. What existing problem does the pull request solve?

The documentation was slightly out of date. Following facebook#10898, which removed the `platform ios` tag, this updates the inner documentation to remove the reference to iOS.
Closes facebook#11993

Differential Revision: D4443723

Pulled By: hramos

fbshipit-source-id: b859c9b0fe1f5e564b919663f8c75401a52ffc9f
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
Summary:
> Explain the **motivation** for making this change. What existing problem does the pull request solve?

The documentation was slightly out of date. Following facebook#10898, which removed the `platform ios` tag, this updates the inner documentation to remove the reference to iOS.
Closes facebook#11993

Differential Revision: D4443723

Pulled By: hramos

fbshipit-source-id: b859c9b0fe1f5e564b919663f8c75401a52ffc9f
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
Summary:
> Explain the **motivation** for making this change. What existing problem does the pull request solve?

The documentation was slightly out of date. Following facebook#10898, which removed the `platform ios` tag, this updates the inner documentation to remove the reference to iOS.
Closes facebook#11993

Differential Revision: D4443723

Pulled By: hramos

fbshipit-source-id: b859c9b0fe1f5e564b919663f8c75401a52ffc9f
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
Summary:
> Explain the **motivation** for making this change. What existing problem does the pull request solve?

The documentation was slightly out of date. Following facebook#10898, which removed the `platform ios` tag, this updates the inner documentation to remove the reference to iOS.
Closes facebook#11993

Differential Revision: D4443723

Pulled By: hramos

fbshipit-source-id: b859c9b0fe1f5e564b919663f8c75401a52ffc9f
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
Summary:
> Explain the **motivation** for making this change. What existing problem does the pull request solve?

The documentation was slightly out of date. Following facebook#10898, which removed the `platform ios` tag, this updates the inner documentation to remove the reference to iOS.
Closes facebook#11993

Differential Revision: D4443723

Pulled By: hramos

fbshipit-source-id: b859c9b0fe1f5e564b919663f8c75401a52ffc9f
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
Summary:
> Explain the **motivation** for making this change. What existing problem does the pull request solve?

The documentation was slightly out of date. Following facebook#10898, which removed the `platform ios` tag, this updates the inner documentation to remove the reference to iOS.
Closes facebook#11993

Differential Revision: D4443723

Pulled By: hramos

fbshipit-source-id: b859c9b0fe1f5e564b919663f8c75401a52ffc9f
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
Summary:
> Explain the **motivation** for making this change. What existing problem does the pull request solve?

The documentation was slightly out of date. Following facebook#10898, which removed the `platform ios` tag, this updates the inner documentation to remove the reference to iOS.
Closes facebook#11993

Differential Revision: D4443723

Pulled By: hramos

fbshipit-source-id: b859c9b0fe1f5e564b919663f8c75401a52ffc9f
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
Summary:
> Explain the **motivation** for making this change. What existing problem does the pull request solve?

The documentation was slightly out of date. Following facebook#10898, which removed the `platform ios` tag, this updates the inner documentation to remove the reference to iOS.
Closes facebook#11993

Differential Revision: D4443723

Pulled By: hramos

fbshipit-source-id: b859c9b0fe1f5e564b919663f8c75401a52ffc9f
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
Summary:
> Explain the **motivation** for making this change. What existing problem does the pull request solve?

The documentation was slightly out of date. Following facebook#10898, which removed the `platform ios` tag, this updates the inner documentation to remove the reference to iOS.
Closes facebook#11993

Differential Revision: D4443723

Pulled By: hramos

fbshipit-source-id: b859c9b0fe1f5e564b919663f8c75401a52ffc9f
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
Summary:
> Explain the **motivation** for making this change. What existing problem does the pull request solve?

The documentation was slightly out of date. Following facebook#10898, which removed the `platform ios` tag, this updates the inner documentation to remove the reference to iOS.
Closes facebook#11993

Differential Revision: D4443723

Pulled By: hramos

fbshipit-source-id: b859c9b0fe1f5e564b919663f8c75401a52ffc9f
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
Summary:
> Explain the **motivation** for making this change. What existing problem does the pull request solve?

The documentation was slightly out of date. Following facebook#10898, which removed the `platform ios` tag, this updates the inner documentation to remove the reference to iOS.
Closes facebook#11993

Differential Revision: D4443723

Pulled By: hramos

fbshipit-source-id: b859c9b0fe1f5e564b919663f8c75401a52ffc9f
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
Summary:
> Explain the **motivation** for making this change. What existing problem does the pull request solve?

The documentation was slightly out of date. Following facebook#10898, which removed the `platform ios` tag, this updates the inner documentation to remove the reference to iOS.
Closes facebook#11993

Differential Revision: D4443723

Pulled By: hramos

fbshipit-source-id: b859c9b0fe1f5e564b919663f8c75401a52ffc9f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants