Skip to content

Conversation

@frantic
Copy link
Contributor

@frantic frantic commented Jan 6, 2017

I noticed that any link pointing to React Native website has a very generic title:
"React Native | A framework for building native apps using React". Using the Sharing Debugger
https://developers.facebook.com/tools/debug/sharing/ I found that we are setting og:url which
acts as redirect for Facebook crawlers. However, path is never set for <Site> element, which
means we always get a URL to the index page with the generic title mentioned above.

Before:
screen shot 2017-01-05 at 4 57 38 pm

After:
screen shot 2017-01-05 at 5 02 11 pm

I noticed that any link pointing to React Native website has a very generic title:
"React Native | A framework for building native apps using React". Using the Sharing Debugger
https://developers.facebook.com/tools/debug/sharing/ I found that we are setting `og:url` which
acts as redirect for Facebook crawlers. However, `path` is never set for `<Site>` element, which
means we always get a URL to the index page with the generic title mentioned above.
@facebook-github-bot
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @hramos and @yungsters to be potential reviewers.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jan 6, 2017
@hramos
Copy link
Contributor

hramos commented Jan 6, 2017

@frantic path is used in BlogPostLayout in order to generate the correct preview for a blog post whenever it contains a "hero" image.

For example, the Meetup Recap blog post has the following share preview image:
screen shot 2017-01-06 at 2 11 39 pm

@hramos
Copy link
Contributor

hramos commented Jan 6, 2017

Err I should say, this is used in the blog layout because it is inside a blog/ subpath. The hero image is not set via og:url, but it's an example of where the path props is used.

@hramos hramos closed this Feb 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants