Switched to npm hosted boost lib #11469

bestander · 2016-12-14T21:35:26Z

Boost is officially hosted on SourceForge which has ab SSL problem that Gradle complains about and also it is sometimes unavailable.
I switched to using npm hosted (yarnpkg mirrored for performance) boost lib exactly the same as from Source Forge.

Other alternatives considered:

CDN e.g. mirror.nienbo.com started responding with 4XX code when requested by Gradle
File sharing like DropBox are not for mass anonymous downloads
Github is not good for binary files and is throttled for anonymous raw file downloads
S3 or similar. Requires amazon account for maintenance and does not expose semver API and other nice features that npm has

In the future I'd like to try Yarn as dependency management tool for bridge builds, this could be the first step.

Test plan (required)

Circle (testing with caches cleaned)
./gradlew ReactAndroid:packageReactNdkLibsForBuck (check twice to make sure caches work)
REACT_NATIVE_BOOST_PATH=./bridge-dependencies/node_modules/boost-react-native-bundle ./gradlew ReactAndroid:packageReactNdkLibsForBuck (check twice to make sure caches work)

facebook-github-bot · 2016-12-14T21:35:31Z

By analyzing the blame information on this pull request, we identified @rigdern and @javache to be potential reviewers.

bestander · 2016-12-14T21:35:33Z

cc @mkonicek

bestander · 2016-12-14T21:37:10Z

Restarted build with no caches: https://circleci.com/gh/facebook/react-native/14122

bestander · 2016-12-14T22:27:42Z

The npm package is temporary, don't merge yet.

hey99xx · 2016-12-15T07:12:41Z

Github is not good for binary files and is throttled for anonymous raw file downloads

How is this different that rest of the dependencies such as glog or folly? As far as I see they're also hosted in Github and there's no throttling happening when we download their zip files.

Is this a problem only because Boost has a larger size than the others? I think if that's possible (uploading either the zip file or the source code to Github), it would be more consistent with the rest of the gradle script.

Also is there a documentation about throttling? This page https://help.github.com/articles/distributing-large-binaries/ reads it's a valid use case.

ide · 2016-12-15T09:06:18Z

What if we kept just the source code (the entire boost subdirectory) plus license, tar.gz'd it back up, and then just committed that tarball to this repo and added it to .npmignore? I did a quick experiment, with gzip -9 the tarball is about 9.7MB, it's literally over 10x smaller. Also I find it decompresses faster.

boost_1_57_0-lite.tar.gz

bestander · 2016-12-15T11:47:45Z

@ide, it would be better from licensing points of view if it is not committed to RN GitHub repo.
Would you be able to push an npm package with your boost?

ide · 2016-12-15T20:37:48Z

@bestander I put the files up on GitHub, this way other people can maintain it too: https://github.com/react-native-community/boost-for-react-native/releases/tag/v1.57.0-0. There's both a .tar.gz (9.6MB) and .zip file (12MB).

hey99xx · 2016-12-16T05:50:17Z

@ide Thanks for taking the initiative. However @bestander has a point about licensing. IANAL but Boost's license at http://www.boost.org/users/license.html reads to be very permissive, so we're likely to be ok.

mkonicek · 2016-12-16T14:11:44Z

ReactAndroid/build.gradle

+            fcp.exclude()
+        }
+    }
+}


Why this extra code rather than only replacing the URL?

mkonicek · 2016-12-16T14:12:27Z

Thanks for doing this @bestander, thank you for the help @ide!

@facebook-github-bot shipit

facebook-github-bot · 2016-12-16T14:13:10Z

@mkonicek has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: Improvement over #11469. Depends on react-native-community/boost-for-react-native#1, **don't merge before it is fixed**. It would be more in line with other dependencies to depend only on github for thirdparty bridge dependencies. **Test plan (required)** - Circle (testing with caches cleaned) - ./gradlew ReactAndroid:packageReactNdkLibsForBuck (check twice to make sure caches work) REACT_NATIVE_BOOST_PATH=./path-to-local-boost/ - ./gradlew ReactAndroid:packageReactNdkLibsForBuck (check twice to make sure caches work) Closes #11511 Differential Revision: D4348098 fbshipit-source-id: 5c2f25cc395ae0cad19d56b7c0b2b102513580fb

Summary: Boost is officially hosted on SourceForge which has ab SSL problem that Gradle complains about and also it is sometimes unavailable. I switched to using npm hosted (yarnpkg mirrored for performance) boost lib exactly the same as from Source Forge. Other alternatives considered: - CDN e.g. mirror.nienbo.com started responding with 4XX code when requested by Gradle - File sharing like DropBox are not for mass anonymous downloads - Github is not good for binary files and is throttled for anonymous raw file downloads - S3 or similar. Requires amazon account for maintenance and does not expose semver API and other nice features that npm has In the future I'd like to try Yarn as dependency management tool for bridge builds, this could be the first step. **Test plan (required)** - Circle (testing with caches cleaned) - `./gradlew ReactAndroid:packageReactNdkLibsForBuck` (check twice to make sure caches work) - `REACT_NATIVE_BOOST_PATH=./bridge-dependencies/node_modules/boost-react-native-bundle ./ Closes #11469 Differential Revision: D4339446 Pulled By: mkonicek fbshipit-source-id: ccc9196e9b675c16a235a318c4861aaa4e263d6e

Summary: Improvement over #11469. Depends on react-native-community/boost-for-react-native#1, **don't merge before it is fixed**. It would be more in line with other dependencies to depend only on github for thirdparty bridge dependencies. **Test plan (required)** - Circle (testing with caches cleaned) - ./gradlew ReactAndroid:packageReactNdkLibsForBuck (check twice to make sure caches work) REACT_NATIVE_BOOST_PATH=./path-to-local-boost/ - ./gradlew ReactAndroid:packageReactNdkLibsForBuck (check twice to make sure caches work) Closes #11511 Differential Revision: D4348098 fbshipit-source-id: 5c2f25cc395ae0cad19d56b7c0b2b102513580fb

Summary: Boost is officially hosted on SourceForge which has ab SSL problem that Gradle complains about and also it is sometimes unavailable. I switched to using npm hosted (yarnpkg mirrored for performance) boost lib exactly the same as from Source Forge. Other alternatives considered: - CDN e.g. mirror.nienbo.com started responding with 4XX code when requested by Gradle - File sharing like DropBox are not for mass anonymous downloads - Github is not good for binary files and is throttled for anonymous raw file downloads - S3 or similar. Requires amazon account for maintenance and does not expose semver API and other nice features that npm has In the future I'd like to try Yarn as dependency management tool for bridge builds, this could be the first step. **Test plan (required)** - Circle (testing with caches cleaned) - `./gradlew ReactAndroid:packageReactNdkLibsForBuck` (check twice to make sure caches work) - `REACT_NATIVE_BOOST_PATH=./bridge-dependencies/node_modules/boost-react-native-bundle ./ Closes facebook#11469 Differential Revision: D4339446 Pulled By: mkonicek fbshipit-source-id: ccc9196e9b675c16a235a318c4861aaa4e263d6e

Summary: Improvement over facebook#11469. Depends on react-native-community/boost-for-react-native#1, **don't merge before it is fixed**. It would be more in line with other dependencies to depend only on github for thirdparty bridge dependencies. **Test plan (required)** - Circle (testing with caches cleaned) - ./gradlew ReactAndroid:packageReactNdkLibsForBuck (check twice to make sure caches work) REACT_NATIVE_BOOST_PATH=./path-to-local-boost/ - ./gradlew ReactAndroid:packageReactNdkLibsForBuck (check twice to make sure caches work) Closes facebook#11511 Differential Revision: D4348098 fbshipit-source-id: 5c2f25cc395ae0cad19d56b7c0b2b102513580fb

since the old boost location was giving ssl errors, facebook has moved it to ashared repo. for more info, see: facebook#11469

Summary: Boost is officially hosted on SourceForge which has ab SSL problem that Gradle complains about and also it is sometimes unavailable. I switched to using npm hosted (yarnpkg mirrored for performance) boost lib exactly the same as from Source Forge. Other alternatives considered: - CDN e.g. mirror.nienbo.com started responding with 4XX code when requested by Gradle - File sharing like DropBox are not for mass anonymous downloads - Github is not good for binary files and is throttled for anonymous raw file downloads - S3 or similar. Requires amazon account for maintenance and does not expose semver API and other nice features that npm has In the future I'd like to try Yarn as dependency management tool for bridge builds, this could be the first step. **Test plan (required)** - Circle (testing with caches cleaned) - `./gradlew ReactAndroid:packageReactNdkLibsForBuck` (check twice to make sure caches work) - `REACT_NATIVE_BOOST_PATH=./bridge-dependencies/node_modules/boost-react-native-bundle ./ Closes facebook#11469 Differential Revision: D4339446 Pulled By: mkonicek fbshipit-source-id: ccc9196e9b675c16a235a318c4861aaa4e263d6e

Summary: Improvement over facebook#11469. Depends on react-native-community/boost-for-react-native#1, **don't merge before it is fixed**. It would be more in line with other dependencies to depend only on github for thirdparty bridge dependencies. **Test plan (required)** - Circle (testing with caches cleaned) - ./gradlew ReactAndroid:packageReactNdkLibsForBuck (check twice to make sure caches work) REACT_NATIVE_BOOST_PATH=./path-to-local-boost/ - ./gradlew ReactAndroid:packageReactNdkLibsForBuck (check twice to make sure caches work) Closes facebook#11511 Differential Revision: D4348098 fbshipit-source-id: 5c2f25cc395ae0cad19d56b7c0b2b102513580fb

facebook-github-bot added the GH Review: review-needed label Dec 14, 2016

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 14, 2016

Switched to npm hosted boost lib

f14aefd

bestander force-pushed the boost-npm-hosted branch from 0343f71 to f14aefd Compare December 15, 2016 14:37

moved bridge compilation higher

0e2fb97

mkonicek reviewed Dec 16, 2016

View reviewed changes

ReactAndroid/build.gradle

fcp.exclude()

}

}

}

Copy link

Contributor

mkonicek Dec 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this extra code rather than only replacing the URL?

facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Dec 16, 2016

facebook-github-bot closed this in 0579efe Dec 16, 2016

bestander mentioned this pull request Dec 16, 2016

boost is downloaded from https://github.com/react-native-community/boost #11511

Closed

belemaire mentioned this pull request Dec 20, 2016

SSLHandshakeException during downloadBoost task when building react-native Android #11569

Closed

ide mentioned this pull request Dec 29, 2016

[0.40] Commits to cherry-pick #11423

Closed

bnns pushed a commit to bloomfire/react-native that referenced this pull request Feb 7, 2017

BF-11624 boost download location

6e8d52e

since the old boost location was giving ssl errors, facebook has moved it to ashared repo. for more info, see: facebook#11469

bnns mentioned this pull request Feb 7, 2017

BF-11624 boost download location bloomfire/react-native#9

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switched to npm hosted boost lib #11469

Switched to npm hosted boost lib #11469

bestander commented Dec 14, 2016 •

edited

Loading

facebook-github-bot commented Dec 14, 2016

bestander commented Dec 14, 2016

bestander commented Dec 14, 2016

bestander commented Dec 14, 2016

hey99xx commented Dec 15, 2016 •

edited

Loading

ide commented Dec 15, 2016 •

edited

Loading

bestander commented Dec 15, 2016

ide commented Dec 15, 2016

hey99xx commented Dec 16, 2016

mkonicek Dec 16, 2016

mkonicek commented Dec 16, 2016

facebook-github-bot commented Dec 16, 2016

Switched to npm hosted boost lib #11469

Switched to npm hosted boost lib #11469

Conversation

bestander commented Dec 14, 2016 • edited Loading

facebook-github-bot commented Dec 14, 2016

bestander commented Dec 14, 2016

bestander commented Dec 14, 2016

bestander commented Dec 14, 2016

hey99xx commented Dec 15, 2016 • edited Loading

ide commented Dec 15, 2016 • edited Loading

bestander commented Dec 15, 2016

ide commented Dec 15, 2016

hey99xx commented Dec 16, 2016

mkonicek Dec 16, 2016

Choose a reason for hiding this comment

mkonicek commented Dec 16, 2016

facebook-github-bot commented Dec 16, 2016

bestander commented Dec 14, 2016 •

edited

Loading

hey99xx commented Dec 15, 2016 •

edited

Loading

ide commented Dec 15, 2016 •

edited

Loading