Update gradle-download-task from 2.0.0 to 3.1.2 to fix boost zip down… #11298
Conversation
|
By analyzing the blame information on this pull request, we identified @christopherdro and @mikelambert to be potential reviewers. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
This is awesome, thanks! Android tests are currently broken on master but once they're fixed could you rebase this to have green Android tests on the PR? |
|
I updated the PR, all those tests are green now. Can you help to have a review? Thanks. |
|
@facebook-github-bot shipit |
|
Could you also update https://github.com/facebook/react-native/blob/master/build.gradle#L10. Not sure if it's too late since it was shipped (was 8 hours so it might have failed). |
|
I can try it, but not sure it is the right process or not. |
|
@facebook-github-bot shipit |
Summary: Small pull request **motivation** The doc 'Building React Native from source' is not up to date now. While i try to build from the source my self, the gradle-download-task(2.0.0) will always fail to download boost zip with a failure of 403. After i upgrade the gradle-download-task to 3.1.2, the download works well. **Test plan (required)** I tested to build the source myself, it works. This is non-code update, it is document update, hope to help other people who get the same download failure. **Code formatting** Non-code update PR. Closes #11298 Differential Revision: D4288387 fbshipit-source-id: 5e6feef1ea80f7e3feddcc7e4abf2b5cea82f08f
Summary: Small pull request **motivation** The doc 'Building React Native from source' is not up to date now. While i try to build from the source my self, the gradle-download-task(2.0.0) will always fail to download boost zip with a failure of 403. After i upgrade the gradle-download-task to 3.1.2, the download works well. **Test plan (required)** I tested to build the source myself, it works. This is non-code update, it is document update, hope to help other people who get the same download failure. **Code formatting** Non-code update PR. Closes facebook#11298 Differential Revision: D4288387 fbshipit-source-id: 5e6feef1ea80f7e3feddcc7e4abf2b5cea82f08f
Small pull request
motivation
The doc 'Building React Native from source' is not up to date now.
While i try to build from the source my self, the gradle-download-task(2.0.0) will always fail to download boost zip with a failure of 403.
After i upgrade the gradle-download-task to 3.1.2, the download works well.
Test plan (required)
I tested to build the source myself, it works.
This is non-code update, it is document update, hope to help other people who get the same download failure.
Code formatting
Non-code update PR.