Navigator does not pop view until animation has stopped

[johanneslumpe]

The Navigator component in question is the JS-reimplementation. Here is an example using a ListView. Notice that the back button does not work, until the ListView has stopped scrolling:

3.8MB gif coming up:

[ericvicenti]

Is that a normal ScrollView? I couldn't replicate this in the navbar example. Could you post a simplified code snippet that shows this bug?

[johanneslumpe]

That'S a ListView inside the JS Navigator. Interestingly I also cannot reproduce it in the UIExplorer examples. I'll dig a little deeper and report back when I found something!

[johanneslumpe]

I was actually able to confirm the same behavior in the UIExplorer, after adding a timeout, which would call navigator.pop() after 1 second. As long as I was scrolling, or the scrollview was moving, the timeout function did not fire. Only ever after the scrolling stopped, the view would be popped. I'll see that I get a basic example done as soon as possible.

[tadeuzagallo]

It's probably already been fixed on 75e4e12

Before that commit, timers were added to the runloop in NSDefaultRunLoopMode, which means it wouldn't fire during UI events, when it's in UITrackingRunLoopMode. Now we're running in NSRunLoopCommonModes which should still trigger it.

The old code is here: https://github.com/facebook/react-native/blob/8a57c4e9807cee5a4196cc50b40bc9e040c02398/React/Modules/RCTTiming.m

Could you confirm if it fixed your problem?

[johanneslumpe]

@tadeuzagallo yeah it's fixed now in 0.4 :)

[deelite1]

Crystalmurray 200@gmail.com
On Apr 17, 2015 9:56 AM, "Johannes Lumpe" notifications@github.com wrote:

@tadeuzagallo https://github.com/tadeuzagallo yeah it's fixed now in 0.4
:)

—
Reply to this email directly or view it on GitHub
#864 (comment)
.