Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Modal in an app with status bar hidden = true results in status bar being shown #8627

Closed
RonakKhandelwal opened this issue Jul 7, 2016 · 22 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@RonakKhandelwal
Copy link

Bug?

@satya164
Copy link
Contributor

satya164 commented Jul 7, 2016

Please mention your React Native version and platform.

@RonakKhandelwal
Copy link
Author

react-native-cli: 0.2.0
react-native: 0.24.1
platform: android
dev platform: macOSX

@RonakKhandelwal
Copy link
Author

reproducible????

@satya164
Copy link
Contributor

satya164 commented Jul 8, 2016

Can you also post a screenshot? Are you referring to the grey line at the top?

@RonakKhandelwal
Copy link
Author

screen shot 2016-07-08 at 3 02 59 pm

screen shot 2016-07-08 at 3 02 48 pm

@RonakKhandelwal
Copy link
Author

the status bar

@nihgwu
Copy link
Contributor

nihgwu commented Jul 8, 2016

I think the StatusBar on Modal can't be controlled and will be a blur one on Android right now.
I remembered there was a PR to add support for translucentStatusBar to Modal but caused test fail, then the PR was not shipped eventually, around 0.27-0.28

@nihgwu
Copy link
Contributor

nihgwu commented Jul 8, 2016

Well I noticed that you are using RN0.24, so the StatusBar on Modal will always gray and can't be controlled, after 0.28( or 0.27) it will be a translucent one but still can't make it transparent

@nihgwu
Copy link
Contributor

nihgwu commented Jul 8, 2016

Here it is #7157 it was introduced in 0.27

@satya164
Copy link
Contributor

satya164 commented Jul 8, 2016

cc @jemise111

@nihgwu
Copy link
Contributor

nihgwu commented Jul 8, 2016

@satya164 do you work for 24 hours a day... find you at any time and everywhere, it's crazy

@satya164
Copy link
Contributor

satya164 commented Jul 8, 2016

@nihgwu Haha. I try to be online when I can :D

@nihgwu
Copy link
Contributor

nihgwu commented Jul 8, 2016

@satya164 It will be so great if you have any time to take a look at this one 1048e5d
It's really a breaking change and i'm sure it will Influence the others
I was trapped by that for days before find the cause and revert that commit manually to avoid the issue #8607

@nihgwu
Copy link
Contributor

nihgwu commented Jul 8, 2016

actually for this issue, there are two different StatusBar, turn on the hidden prop will hide the StatusBar on the View under the Modal , the showing StatusBar is on Modal and can't be controlled or hidden before RN0.27.
so it's not an issue for the newest version

@satya164
Copy link
Contributor

satya164 commented Jul 8, 2016

@nihgwu Sorry, I've no context on the code.

@RonakKhandelwal
Copy link
Author

Ohk so versio issue I guess

@kfiroo
Copy link

kfiroo commented Sep 8, 2016

@nihgwu I'm having the same issue with RN0.32.0.
I have a view that hides the status bar and opens a Modal.
The Modal shows the status bar.
You said it's not an issue after RN0.27.0 - what did you mean? Can I control the status bar for the modal view somehow?
Thanks

@nihgwu
Copy link
Contributor

nihgwu commented Sep 8, 2016

@kfiroo I've explained #8627 (comment) those are two different StatusBar on View an Modal, you can't control the StatusBar on Modal right now

@kfiroo
Copy link

kfiroo commented Sep 9, 2016

@nihgwu Ok, I thought you meant that there is a way after RN27 :)
Thanks!

@ShaikhKabeer
Copy link

ShaikhKabeer commented Jan 11, 2018

Just go to styles.xml of android/app/src/main/res/values/styles.xml and put this code in Base application theme

`

<style name="AppTheme" parent="Theme.ReactNative.AppCompat.Light.NoActionBar.FullScreen"> </style>

`

After putting code, remove generated folders from android/app/build/generated folder and again do
react-native run-android . It will work

@netsmertia
Copy link

I am still facing the same issue. Is there any react-native solution.

@thambt
Copy link

thambt commented May 16, 2018

@ShaikhKabeer thanks man!. U save me.

@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

8 participants