Image with invalid source URI crashes in 0.18 on Android

[thomdixon]

Easy enough to reproduce:

Use <Image source={{uri: null}} /> and it will crash your application. Likewise, invalid URIs, such as <Image source={{uri: '//facebook.github.io/react-native/img/header_logo.png'}} /> will also crash.

This is because line 279 in ReactImageView.java of ReactAndroid passes a null URI to line 103 in ImageRequestBuilder.java of fresco that calls Preconditions.checkNotNull on the null uri, which throws a NPE.

[facebook-github-bot]

Hey thomdixon, thanks for reporting this issue!

React Native, as you've probably heard, is getting really popular and truth is we're getting a bit overwhelmed by the activity surrounding it. There are just too many issues for us to manage properly.

• If you don't know how to do something or something is not working as you expect but not sure it's a bug, please ask on StackOverflow with the tag react-native or for more real time interactions, ask on Discord in the #react-native channel.
• If this is a feature request or a bug that you would like to be fixed, please report it on Product Pains. It has a ranking feature that lets us focus on the most important issues the community is experiencing.
• We welcome clear issues and PRs that are ready for in-depth discussion. Please provide screenshots where appropriate and always mention the version of React Native you're using. Thank you for your contributions!

[dmmiller]

I'm going to get a fix in for this. And will get it picked over to 0.19

[thomdixon]

Thanks so much @dmmiller!!!

[natdm]

Is this totally fixed? I'm getting mine to crash on correct image links, but it won't on incorrect image links.

Here's a video of it happening for me.
https://www.youtube.com/watch?v=oqjZ-2zKcO8&feature=youtu.be

[natdm]

It looks like one of my images was broken, still killing the app.

I've got "events" which have pictures in them. One is crashing, the other is not. If I update them all to one image that I know works, it all works fine. If I use the actual links - one event busts, but the others are fine. I'm thinking that event has one broken image. What do you need from me to look in to it more?

[dmmiller]

What version are you still seeing this on? Can you maybe give me the image link that seems to fail? The easiest thing is if you just make a small component with and post a link. I can look further then.