-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'getUri()' cannot override 'getUri()' in 'com.facebook.react.views.imagehelper.ImageSource'; overridden method is final #46155
Comments
|
|
Summary: Fixes following issues: - #46150 - #46155 ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [ANDROID] [FIXED] - Make getUri and isResource open Pull Request resolved: #46152 Reviewed By: NickGerleman, rshest, blakef Differential Revision: D61845164 Pulled By: cortinico fbshipit-source-id: 88ccdad92423b5add9b2fad4c98f296b6cbfb27d
Hi @cortinico , I hope you're doing well. I wanted to check in and ask when we are planning to release this change. We're still unable to use it and are currently facing issues with the Fast Image package. Looking forward to your response! |
Summary: Fixes following issues: - #46150 - #46155 ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [ANDROID] [FIXED] - Make getUri and isResource open Pull Request resolved: #46152 Reviewed By: NickGerleman, rshest, blakef Differential Revision: D61845164 Pulled By: cortinico fbshipit-source-id: 88ccdad92423b5add9b2fad4c98f296b6cbfb27d
We're planning to include this inside 0.75.3: We're going to do release that in the coming days |
Description
'getUri()' cannot override 'getUri()' in 'com.facebook.react.views.imagehelper.ImageSource'; overridden method is final,please use react-native 0.75.2 and react-native-fast-image package
Steps to reproduce
1.yarn add react-native-fast-image
2.yarn android
React Native Version
0.75.2
Affected Platforms
Runtime - Android
Areas
Fabric - The New Renderer
Output of
npx react-native info
Stacktrace or Logs
Reproducer
..
Screenshots and Videos
No response
The text was updated successfully, but these errors were encountered: