Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The min_ios_version_supported is 12.4 and not 13.4 in a new project #41053

Closed
eduardo-santos-tribia opened this issue Oct 18, 2023 · 2 comments
Closed
Assignees
Labels
Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. Needs: Triage 🔍 Platform: iOS iOS applications.

Comments

@eduardo-santos-tribia
Copy link

Description

This PR added a new Helpers module to packages/react-native/scripts/cocoapods/helpers.rb with the min_ios_version_supported (used in Podfile) returning the value 13.4, but for some reason this value is still 12.4 when creating a new react-native project from scratch or updating react-native to a new version in an existing project.

Am I missing something or this value should be 13.4? I'm using a third party library that requires the minimum iOS target version of 13.0, so I was trying to understand better this "min_ios_version_supported" concept added to react-native.

From my understanding, I should not remove the min_ios_version_supported attribute from Podfile and add the minimum version there explicitly, because react-native already is setting the correct version 13.4 (for my case).

React Native Version

0.72.6

Output of npx react-native info

System:
OS: macOS 14.0
CPU: (10) arm64 Apple M1 Max
Memory: 11.56 GB / 64.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 18.14.0
path: /var/folders/93/dcrjcbf93wq3v4tn6vtfbck40000gn/T/yarn--1697626741264-0.8327458535384211/node
Yarn:
version: 1.22.19
path: /var/folders/93/dcrjcbf93wq3v4tn6vtfbck40000gn/T/yarn--1697626741264-0.8327458535384211/yarn
npm:
version: 9.3.1
path: ~/.nvm/versions/node/v18.14.0/bin/npm
Watchman:
version: 2023.09.04.00
path: /opt/homebrew/bin/watchman
Managers:
CocoaPods: Not Found
SDKs:
iOS SDK:
Platforms:
- DriverKit 23.0
- iOS 17.0
- macOS 14.0
- tvOS 17.0
- watchOS 10.0
Android SDK: Not Found
IDEs:
Android Studio: 2022.3 AI-223.8836.35.2231.10811636
Xcode:
version: 15.0/15A240d
path: /usr/bin/xcodebuild
Languages:
Java:
version: 11.0.16
path: /usr/bin/javac
Ruby:
version: 2.7.8
path: /Users/my-user/.rvm/rubies/ruby-2.7.8/bin/ruby
npmPackages:
"@react-native-community/cli": Not Found
react:
installed: 18.2.0
wanted: 18.2.0
react-native:
installed: 0.72.6
wanted: 0.72.6
react-native-macos: Not Found
npmGlobalPackages:
"react-native": Not Found
Android:
hermesEnabled: true
newArchEnabled: false
iOS:
hermesEnabled: true
newArchEnabled: Not found

Steps to reproduce

  1. Start a new project with npx react-native@latest init AwesomeProject.
  2. Open the node_modules/react-native/scripts/cocoapods/helpers.rb file.
  3. The return value of self.min_ios_version_supported will be 12.4 instead of 13.4.
  4. You can also print the value of min_ios_version_supported in your Podfile to check.

Snack, screenshot, or link to a repository

image
@github-actions github-actions bot added Platform: iOS iOS applications. Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. labels Oct 18, 2023
@github-actions
Copy link

⚠️ Missing Reproducible Example
ℹ️ We could not detect a reproducible example in your issue report. Please provide either:
  • If your bug is UI related: a Snack
  • If your bug is build/update related: use our Reproducer Template. A reproducer needs to be in a GitHub repository under your username.

@cipolleschi
Copy link
Contributor

The commit you mentioned has been picked only for 0.73.0. The min iOS version for 0.72 is still 12.4 and it is correct to stay that way. The change to be on 13.4 will be forced by 0.73.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. Needs: Triage 🔍 Platform: iOS iOS applications.
Projects
None yet
Development

No branches or pull requests

2 participants